fix: improve error handling and clarify SCSS/SASS support limitations - #3
Open
lmn451 wants to merge 7 commits into
Open
fix: improve error handling and clarify SCSS/SASS support limitations#3lmn451 wants to merge 7 commits into
lmn451 wants to merge 7 commits into
Conversation
lmn451
commented
Jan 21, 2026
lmn451
commented
Owner
- Add ScanStats struct to track workspace scan results with error counts
- Log warnings for file read/parse errors instead of silently ignoring them
- Add debug tracing for file read failures in update_document_from_disk
- Document SCSS/SASS/LESS limitations: only CSS custom properties (--var) supported
- Add supported file types table to README.md
- Export ScanStats from lib.rs for external usage
- Add ScanStats struct to track workspace scan results with error counts - Log warnings for file read/parse errors instead of silently ignoring them - Add debug tracing for file read failures in update_document_from_disk - Document SCSS/SASS/LESS limitations: only CSS custom properties (--var) supported - Add supported file types table to README.md - Export ScanStats from lib.rs for external usage
- Add tempfile dependency for test file creation - Make ScanStats::add_error() public for better error reporting - Add automated release script with validation - Add comprehensive integration test suite: - Error path handling tests - LSP protocol compliance tests - Performance benchmark tests - Workspace operations tests - Update release documentation with automated workflow
- Remove unused imports in workspace_integration_test.rs - Add missing tempfile import in performance_integration_test.rs - Fix String::from_utf8 type errors by removing unnecessary borrows - Replace len() >= 1 checks with !is_empty() for clippy compliance - Simplify filter_map to map in completion test - Use if let instead of match for single pattern in hover test - Remove unsupported timeout() method from Command usage
lmn451
force-pushed
the
fix/error-handling-and-scss-docs
branch
from
February 10, 2026 21:34
dfc6a6b to
a456da6
Compare
- Use ls_types::Uri instead of tower_lsp for test imports
- Add Uri::from_str with std::str::FromStr trait
- Fix Uri formatting in logging (use {:?} instead of {})
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.