Fix infinite z-score issue in calculateCriterion() using epsilon correction - #37
Merged
Merged
Conversation
Damien-WangZehou
force-pushed
the
fix/compareC
branch
from
April 30, 2026 12:51
ff4ac4c to
71d215c
Compare
Damien-WangZehou
force-pushed
the
fix/compareC
branch
from
May 1, 2026 14:06
71d215c to
b4ceef1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an epsilon correction to DataProcessed.calculateCriterion() to prevent infinite z-scores when hit rates or false alarm rates take boundary values 0/1.