Add per-process and per-call statistics for time and size metrics#54
Merged
izzet merged 4 commits intollnl:developfrom Mar 20, 2026
Merged
Add per-process and per-call statistics for time and size metrics#54izzet merged 4 commits intollnl:developfrom
izzet merged 4 commits intollnl:developfrom
Conversation
…etrics Separate view-level statistics into two families with unambiguous names: - time_proc_*/size_proc_* for inter-process distribution (renamed from existing) - time_call_*/size_call_* for individual I/O call properties (new) This enables diagnosing *why* a bottleneck is slow (load imbalance vs call jitter vs uniformly slow) rather than just identifying *what* is slow.
hariharan-devarajan
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the statistics and metrics computation pipeline, focusing on clearer separation between per-process and per-call metrics, and improving the calculation and naming of derived statistics. The main changes include new utility functions for column renaming and per-call statistics derivation, updates to aggregation logic, and expanded metric calculations for both process-level and call-level views.
Statistics and column handling improvements:
build_view_rename_mapto standardize column names for view-level statistics, ensuring per-process and per-call metrics are clearly distinguished and fixing naming inconsistencies.derive_call_stats, which computes per-call mean and standard deviation from sum-of-squares columns and cleans up intermediary columns._compute_viewand related functions to handle new per-call and per-process metric suffixes, ensuring correct aggregation functions are applied for each metric type. [1] [2] [3]Metric calculation enhancements:
set_view_metricsto separately compute process-level (*_proc_*) and call-level (*_call_*) metrics, including new fractional metrics for both categories. [1] [2]Consistency and naming updates:
*_proc_*), replacing previous ambiguous suffixes and ensuring consistent metric naming in all views and additional metric calculations. [1] [2]These changes collectively improve the clarity, accuracy, and flexibility of metric computation in the analysis pipeline.