Skip to content

Rename dlio preset to dlio-prev and update test cases#53

Merged
izzet merged 2 commits intollnl:developfrom
izzet:fix/test-e2e-preset-mismatch
Mar 20, 2026
Merged

Rename dlio preset to dlio-prev and update test cases#53
izzet merged 2 commits intollnl:developfrom
izzet:fix/test-e2e-preset-mismatch

Conversation

@izzet
Copy link
Collaborator

@izzet izzet commented Mar 20, 2026

This pull request introduces a new preset configuration for the DLIO analyzer and updates related logic and tests to support both the original and new presets. The main changes are grouped below:

DLIO preset configuration updates:

  • Changed the default name of AnalyzerPresetConfigDLIO from "dlio" to "dlio-prev" to distinguish it from the new preset.
  • Added a new subclass AnalyzerPresetConfigDLIOAILogging with name set to "dlio", representing the updated DLIO preset configuration.

Testing enhancements:

  • Updated tests/test_e2e.py to include a test case for the new "dlio-prev" preset, ensuring coverage for both preset variants.
  • Modified the epoch assignment logic in _test_e2e to trigger for any preset starting with "dlio", supporting both "dlio" and "dlio-prev" presets.

@izzet izzet self-assigned this Mar 20, 2026
@izzet izzet added the bug Something isn't working label Mar 20, 2026
@izzet izzet merged commit ff6eb4e into llnl:develop Mar 20, 2026
4 checks passed
@izzet izzet deleted the fix/test-e2e-preset-mismatch branch March 20, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants