Repository navigation
test: a planted fake git is removed with retries (Windows EBUSY) - #70
Merged
Merged
Conversation
… hold it busy (EBUSY) The 0.33.0 CI run on windows-latest·node24 failed cleanup with EBUSY removing the fake git.exe. Nothing the tests assert changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainfor 0.33.0 (windows-latest · node 24) failed in a cleanup withEBUSYremoving the fakegit.exe(a copy of node) thattest/helpers/fake-git.tsplants fortest/init-clone-cli.test.ts. Every test passed. This is the same class of failure as test: cleanup of planted node copies retries a Windows EBUSY #68.removeWithRetry(test/helpers/fs.ts, from test: cleanup of planted node copies retries a Windows EBUSY #68): thefakeGit()cleanup (used byinit-clone-cliandrepos-cli), thescratch()cleanup inclone.test.ts, and the relative-PATHfindGittest. Nothing the tests assert changes.Test plan
npm run typecheckexits 0.npx vitest run test/clone.test.ts test/init-clone-cli.test.ts test/repos-cli.test.ts --maxWorkers=6on Linux: 59 passed, 2 skipped.--exclude test/ci.test.ts --maxWorkers=6): 129 files passed, 1 skipped; 3274 tests passed, 10 skipped.test/ci.test.tswas not run by hand.