Repository navigation
Credential printing gaps (spec 39) - #67
Merged
Merged
Conversation
… tab / LF / CR first, as a URL parser does (spec 39)
… LF / CR, and only there (spec 39 B′)
…source holds a credential (spec 39 item 8)
…by a label — doctor and cache prune (spec 39 gap 1)
…ellings (spec 39 gap 2)
… labelOf, for spec 39
…ad as a URL, and what still passes (spec 39)
…olding $ or the root (review)
…d the small gaps the review named (spec 39)
…he init answer (review)
…r leaves the rest of a longer one printed (review)
…tarts before another no longer leaves its tail printed (review)
…he same-start choice (review) Comment-only follow-up to round 4's nits: the two-pass safety rests on every cache key ending in -<12 hex>, and the longer key's label at a shared start is deliberate.
…solve gives it (Windows CI) The text carried /tmp/h raw, which on win32 resolves to a drive path, so the segment rule correctly matched nothing; the message now holds the home as the file system reports it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
craftar@0.32.1to npm after approval in thenpmenvironment.doctorandcache pruneprint an entry's name only when a registry row with a clean URL (or the checked workspace) names it. Every other entry reads(a cache entry name — not shown): an orphan, and every entry whenCRAFTAR_NO_REGISTRYis set or the registry cannot be read. That coversdoctor'snothing names itanda fetch never completedlines, andcache prune's rows, its--jsonpathand its warnings. An entry a flagged row names keeps(a URL with credentials — not shown). With no snapshot, the segment afterforges/in a relayed error is the label. Keys are hidden by merged ranges of the original text, so neither a prefix key nor a key that starts inside another leaves part of a name printed.forge:spellings are refused as a URL with credentials: a single/after the scheme, and a tab, LF or CR inside the scheme or its://. This coverscraftar.yamlandcraftar.local.yaml,init --forgeand its questions, andimport --write-config, which now exits 1 instead of replacing the value. The interactiveinitno longer offers a Forge recorded as a path whose spelling holds a credential.schema: 4or above, a rendered server param holding a credential behind such a control character now fails the plan, as one behind a plain://did.--jsonkey is added or removed. The README has a new to 0.32.1 block.Test plan
npm run typecheck: exit 0 (on 8023ad7, after the bump)npm run build: exit 0;node bin/craftar.js --versionprints0.32.1npm test(vitest,--maxWorkers=6, withouttest/ci.test.ts) on 6f29d36, the same source as HEAD minus the version bump: 123 files passed, 1 skipped; 3087 tests passed, 8 skipped. Oracle skipped (no fixture). No emitter, plan, status or apply path changed.src/before its fix, including the gap-2 CLI tests, the interactive-init test,servedRowand the overlapping-key tests.