Dev - #13
Merged
Merged
Conversation
…otected-set-state]
…n-with-video-player]
Replace the machine-specific ../../../flutterguard path dependency with a pinned git ref (9f9be84, flutterguard_cli 0.7.1) so pub resolution and CI no longer depend on a sibling checkout. AI docs regenerated to match.
tool/generate_agent_indexes.js is now the only hand-edited source for module registration; writeRouteTable() emits apps/flutter_forge/lib/app/router/ app_route_table.dart (DO-NOT-EDIT header). validate_agent_docs.js asserts generate-source == AI_MODULE_INDEX consistency and that every module route is present in the generated route table. Proven single-source via a throwaway dry-run (removing one module drops it from both index and route table).
dio 5.11.0 adds DioExceptionType.transformTimeout, making the error interceptor switch non-exhaustive. Local lock pinned 5.9.2 so the error only surfaced on remote/CI packaging. Add the explicit case and bump the constraint to ^5.11.0 so local == remote (no version-drift landmine). Unit test asserts every DioExceptionType value, including transformTimeout, is forwarded.
Run dart fix --apply in apps/flutter_forge to clear the 192 info-level diagnostics (prefer_const_constructors, prefer_const_literals_to_create_immutables, prefer_final_fields) that made bare flutter analyze exit non-zero. Manually migrate ReorderableListView onReorder -> onReorderItem and drop the now-redundant newIndex adjustment (the new callback pre-adjusts for the removed item). No behavior or layout changes.
Remove --no-fatal-infos --no-fatal-warnings so info/warning diagnostics fail the gate exactly like remote packaging would. Now that the 192-info backlog is cleared, local acceptance matches remote packaging behavior permanently.
Remove the FlutterGuard scan step (it ran from the repo root where no lib/ exists and always failed with an empty match) along with the now-dead pinned checkout + sibling-mv steps. flutterguard_cli remains a pinned git dev dependency and is still enforced by the local quality_gate.sh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.