Update module github.com/pion/rtp to v2#603
Conversation
af8dcab to
ea4c92d
Compare
ea4c92d to
d5c58fc
Compare
d5c58fc to
d3810f8
Compare
19e1778 to
2b93c6c
Compare
892f4d5 to
98be49e
Compare
98be49e to
396ccd2
Compare
396ccd2 to
5a23ecd
Compare
5a23ecd to
c691faf
Compare
c691faf to
aaff524
Compare
aaff524 to
1c628d6
Compare
1c628d6 to
f634979
Compare
a756e2e to
bcb58df
Compare
5be8bf2 to
5dcdf73
Compare
5dcdf73 to
b8ecc83
Compare
b8ecc83 to
8ef3b4c
Compare
8ef3b4c to
fc6a614
Compare
357bb7f to
5fbd841
Compare
5fbd841 to
9d94256
Compare
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the
Comment |
9d94256 to
5795ae4
Compare
5795ae4 to
5538acb
Compare
5538acb to
e12eee3
Compare
e12eee3 to
59ff20f
Compare
59ff20f to
3a12d6e
Compare
3a12d6e to
0062eee
Compare
73f101b to
46c4299
Compare
250adc0 to
06219e1
Compare
06219e1 to
1d396dd
Compare
d82c2f9 to
1d396dd
Compare
| github.com/pion/interceptor v0.1.45 | ||
| github.com/pion/rtcp v1.2.16 | ||
| github.com/pion/rtp v1.10.2 | ||
| github.com/pion/rtp/v2 v2.0.0 |
There was a problem hiding this comment.
🟡 New RTP v2 dependency is declared but never imported anywhere in the codebase
The new dependency is added to the module file (github.com/pion/rtp/v2 at go.mod:21) but no source file imports it, so it is unused and would be removed by go mod tidy.
Impact: The stated migration to RTP v2 is incomplete — all code still uses v1, and the v2 entry is dead weight.
All source files still import v1, not v2
Every .go file in the repository that uses the RTP library imports github.com/pion/rtp (v1), not github.com/pion/rtp/v2. For example:
localtrack.go:29imports"github.com/pion/rtp"pkg/samplebuilder/samplebuilder.go:26imports"github.com/pion/rtp"e2ee/trackdecryptor.go:22imports"github.com/pion/rtp"pkg/interceptor/pacerinteceptor.go:7imports"github.com/pion/rtp"
The old github.com/pion/rtp v1.10.2 is still listed as a direct dependency at go.mod:20 and is still actively used. The go.sum file only contains a /go.mod hash for pion/rtp/v2 (no source hash), confirming no code downloads or uses the v2 module.
Prompt for agents
The PR adds github.com/pion/rtp/v2 as a direct dependency in go.mod but no Go source files import it. All imports throughout the codebase (localtrack.go, pkg/samplebuilder/samplebuilder.go, e2ee/trackdecryptor.go, pkg/interceptor/pacerinteceptor.go, pkg/synchronizer/track.go, etc.) still reference github.com/pion/rtp (v1). Either: (1) update all import paths from github.com/pion/rtp to github.com/pion/rtp/v2 and remove the v1 dependency, or (2) remove the v2 line from go.mod if this migration is not yet ready. Running go mod tidy in the current state would remove the v2 entry automatically.
Was this helpful? React with 👍 or 👎 to provide feedback.
Generated by renovateBot
This PR contains the following updates:
v1.10.2→v2.0.0Release Notes
pion/rtp (github.com/pion/rtp)
v2.0.0Compare Source
v1.10.5Compare Source
Changelog
e61bd16Support multiple sps/pps/vps in h265 AUv1.10.4Compare Source
Changelog
2b19d5bCache SPS/PPS/VPS in H265Payloader0f341d6Check data length it RTP ExtHdr handlersv1.10.3Compare Source
Changelog
ac0f586Skip allocations when reusing VP9 packets (#364)Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.