Skip to content

Update module github.com/pion/rtp to v2#603

Open
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/major-pion-deps
Open

Update module github.com/pion/rtp to v2#603
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/major-pion-deps

Conversation

@renovate

@renovate renovate Bot commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
github.com/pion/rtp v1.10.2v2.0.0 age confidence

Release Notes

pion/rtp (github.com/pion/rtp)

v2.0.0

Compare Source

v1.10.5

Compare Source

Changelog

  • e61bd16 Support multiple sps/pps/vps in h265 AU

v1.10.4

Compare Source

Changelog

  • 2b19d5b Cache SPS/PPS/VPS in H265Payloader
  • 0f341d6 Check data length it RTP ExtHdr handlers

v1.10.3

Compare Source

Changelog


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • "before 9am on monday"
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch from af8dcab to ea4c92d Compare March 1, 2025 22:58
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch from ea4c92d to d5c58fc Compare March 10, 2025 04:46
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch from d5c58fc to d3810f8 Compare March 17, 2025 18:11
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch 2 times, most recently from 19e1778 to 2b93c6c Compare April 8, 2025 11:12
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch 3 times, most recently from 892f4d5 to 98be49e Compare April 29, 2025 18:06
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch from 98be49e to 396ccd2 Compare May 7, 2025 11:05
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch from 396ccd2 to 5a23ecd Compare June 16, 2025 06:04
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch from 5a23ecd to c691faf Compare July 2, 2025 02:29
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch from c691faf to aaff524 Compare July 22, 2025 10:51
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch from aaff524 to 1c628d6 Compare August 10, 2025 14:43
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch from 1c628d6 to f634979 Compare August 28, 2025 06:52
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch 11 times, most recently from a756e2e to bcb58df Compare October 2, 2025 06:01
@renovate renovate Bot changed the title fix(deps): update module github.com/pion/rtp to v2 fix(deps): update module github.com/pion/rtp to v2 - autoclosed Oct 2, 2025
@renovate renovate Bot closed this Oct 2, 2025
@renovate
renovate Bot deleted the renovate/major-pion-deps branch October 2, 2025 09:34
@renovate renovate Bot changed the title fix(deps): update module github.com/pion/rtp to v2 - autoclosed fix(deps): update module github.com/pion/rtp to v2 Oct 6, 2025
@renovate renovate Bot reopened this Oct 6, 2025
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch from 5be8bf2 to 5dcdf73 Compare October 22, 2025 09:09
@renovate renovate Bot changed the title Update module github.com/pion/rtp to v2 fix(deps): update module github.com/pion/rtp to v2 Oct 27, 2025
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch from 5dcdf73 to b8ecc83 Compare November 12, 2025 00:25
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch from b8ecc83 to 8ef3b4c Compare December 2, 2025 20:00
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch from 8ef3b4c to fc6a614 Compare December 15, 2025 17:57
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch 2 times, most recently from 357bb7f to 5fbd841 Compare January 20, 2026 13:52
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch from 5fbd841 to 9d94256 Compare February 2, 2026 21:41
@coderabbitai

coderabbitai Bot commented Feb 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Comment @coderabbitai help to get the list of available commands and usage tips.

@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch from 9d94256 to 5795ae4 Compare February 12, 2026 12:03
@renovate renovate Bot changed the title fix(deps): update module github.com/pion/rtp to v2 Update module github.com/pion/rtp to v2 Feb 23, 2026
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch from 5795ae4 to 5538acb Compare February 23, 2026 17:30
@renovate renovate Bot changed the title Update module github.com/pion/rtp to v2 fix(deps): update module github.com/pion/rtp to v2 Mar 4, 2026
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch from 5538acb to e12eee3 Compare March 5, 2026 14:43
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch from e12eee3 to 59ff20f Compare March 13, 2026 17:04
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch from 59ff20f to 3a12d6e Compare March 23, 2026 05:03
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch from 3a12d6e to 0062eee Compare April 1, 2026 16:12
@renovate renovate Bot changed the title fix(deps): update module github.com/pion/rtp to v2 Update module github.com/pion/rtp to v2 Apr 8, 2026
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch 2 times, most recently from 73f101b to 46c4299 Compare April 29, 2026 12:11
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch 2 times, most recently from 250adc0 to 06219e1 Compare May 18, 2026 18:06
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch from 06219e1 to 1d396dd Compare May 28, 2026 14:59
@renovate renovate Bot changed the title Update module github.com/pion/rtp to v2 Update module github.com/pion/rtp to v2 - autoclosed May 29, 2026
@renovate renovate Bot closed this May 29, 2026
@renovate renovate Bot changed the title Update module github.com/pion/rtp to v2 - autoclosed Update module github.com/pion/rtp to v2 Jun 1, 2026
@renovate renovate Bot reopened this Jun 1, 2026
@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch from d82c2f9 to 1d396dd Compare June 1, 2026 04:48

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 1 additional finding in Devin Review.

Open in Devin Review

Comment thread go.mod
github.com/pion/interceptor v0.1.45
github.com/pion/rtcp v1.2.16
github.com/pion/rtp v1.10.2
github.com/pion/rtp/v2 v2.0.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 New RTP v2 dependency is declared but never imported anywhere in the codebase

The new dependency is added to the module file (github.com/pion/rtp/v2 at go.mod:21) but no source file imports it, so it is unused and would be removed by go mod tidy.

Impact: The stated migration to RTP v2 is incomplete — all code still uses v1, and the v2 entry is dead weight.

All source files still import v1, not v2

Every .go file in the repository that uses the RTP library imports github.com/pion/rtp (v1), not github.com/pion/rtp/v2. For example:

  • localtrack.go:29 imports "github.com/pion/rtp"
  • pkg/samplebuilder/samplebuilder.go:26 imports "github.com/pion/rtp"
  • e2ee/trackdecryptor.go:22 imports "github.com/pion/rtp"
  • pkg/interceptor/pacerinteceptor.go:7 imports "github.com/pion/rtp"

The old github.com/pion/rtp v1.10.2 is still listed as a direct dependency at go.mod:20 and is still actively used. The go.sum file only contains a /go.mod hash for pion/rtp/v2 (no source hash), confirming no code downloads or uses the v2 module.

Prompt for agents
The PR adds github.com/pion/rtp/v2 as a direct dependency in go.mod but no Go source files import it. All imports throughout the codebase (localtrack.go, pkg/samplebuilder/samplebuilder.go, e2ee/trackdecryptor.go, pkg/interceptor/pacerinteceptor.go, pkg/synchronizer/track.go, etc.) still reference github.com/pion/rtp (v1). Either: (1) update all import paths from github.com/pion/rtp to github.com/pion/rtp/v2 and remove the v1 dependency, or (2) remove the v2 line from go.mod if this migration is not yet ready. Running go mod tidy in the current state would remove the v2 entry automatically.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants