Make Ingress optional and ingressClass configurable#98
Open
p4block wants to merge 1 commit intolivekit:masterfrom
Open
Make Ingress optional and ingressClass configurable#98p4block wants to merge 1 commit intolivekit:masterfrom
p4block wants to merge 1 commit intolivekit:masterfrom
Conversation
|
Pablo Moyano seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
the ingress is optional with PS: i really dislike that schema |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bigger rework of the chart comes to my mind but this suffices for my usecase.
Should be compatible with previous installs with no intervention.
Commenting on related things, fully decoupling the helmchart from gke/aws/do would be optimal, as there's really nothing that actually ties LiveKit to them. Ingress should also be decoupled from the loadbalancer, as TLS-terminating LBs can avoid the need for one if the user configured them but other people may use service+ingress instead.
Bringing up the chart to ie. Bitnami standard to allow fully changing every parameter would be a lot of work but ultimately desirable. I totally understand this may be out of scope for the chart and "users bring their your own yaml" may be preferred.