feat: add prometheus credentials to helm chart#96
Open
holzgeist wants to merge 1 commit intolivekit:masterfrom
Open
feat: add prometheus credentials to helm chart#96holzgeist wants to merge 1 commit intolivekit:masterfrom
holzgeist wants to merge 1 commit intolivekit:masterfrom
Conversation
Author
|
@davidzhao this is an attempt to bring livekit/livekit#2252 over to the helm chart. It's currently completely untested because I don't fully understand how to test local changes with flux/helm/... yet. |
holzgeist
force-pushed
the
feat-add-prometheus-credentials
branch
from
24ef91f to
8d6b2d1
Compare
Author
|
@davidzhao Meantime I figured out how to develop and test helm charts 😄 Here's an update PR that allows credentials to be set. They are
|
wrenix
suggested changes
Apr 4, 2025
Comment on lines
+43
to
+44
| {{- if (include "livekit-server.prometheus_port" .) }} | ||
| - port: {{ include "livekit-server.prometheus_port" . }} |
There was a problem hiding this comment.
Suggested change
| {{- if (include "livekit-server.prometheus_port" .) }} | |
| - port: {{ include "livekit-server.prometheus_port" . }} | |
| {{- with (include "livekit-server.prometheus_port" .) }} | |
| - port: {{ . }} |
Comment on lines
+79
to
+82
| {{- if (include "livekit-server.prometheus_port" .) }} | ||
| - name: metrics | ||
| containerPort: {{ .Values.livekit.prometheus_port }} | ||
| hostPort: {{ .Values.livekit.prometheus_port }} | ||
| containerPort: {{ include "livekit-server.prometheus_port" . }} | ||
| hostPort: {{ include "livekit-server.prometheus_port" . }} |
There was a problem hiding this comment.
Suggested change
| {{- if (include "livekit-server.prometheus_port" .) }} | |
| - name: metrics | |
| containerPort: {{ .Values.livekit.prometheus_port }} | |
| hostPort: {{ .Values.livekit.prometheus_port }} | |
| containerPort: {{ include "livekit-server.prometheus_port" . }} | |
| hostPort: {{ include "livekit-server.prometheus_port" . }} | |
| {{- with (include "livekit-server.prometheus_port" .) }} | |
| - name: metrics | |
| containerPort: {{ . }} | |
| hostPort: {{ . }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.