Open
Conversation
|
|
kerkmann
force-pushed
the
add-traefik-support
branch
from
9370a03 to
79bb60c
Compare
Member
|
this looks good! could you update the docs in the sample config as well? that'll let others know about traefik support |
kerkmann
force-pushed
the
add-traefik-support
branch
from
79bb60c to
f8b06f0
Compare
Author
|
Thanks for the feedback, I've added it. I hope that's enough, feel free to ask for changes. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
traefikit's important that theingressClassNameistraefik. Tested it and it's working on with that changes. :)