Fix bug in EOS for data streams#357
Merged
Merged
Conversation
MaxHeimbrock
changed the base branch from
main
to
max/final-docs-update-for-2.0.0
July 20, 2026 10:35
MaxHeimbrock
changed the title
MaxHeimbrock
force-pushed
the
max/datastream-incemental-eos-drain
branch
from
July 20, 2026 12:14
1c980d4 to
72f668d
Compare
MaxHeimbrock
force-pushed
the
max/datastream-incemental-eos-drain
branch
from
July 20, 2026 12:15
72f668d to
b12adc9
Compare
MaxHeimbrock
changed the base branch from
max/final-docs-update-for-2.0.0
to
main
July 20, 2026 12:16
MaxHeimbrock
marked this pull request as ready for review
July 20, 2026 12:16
MaxHeimbrock
requested review from
cloudwebrtc,
ladvoc and
xianshijing-lk
as code owners
July 20, 2026 12:16
MaxHeimbrock
commented
Jul 20, 2026
| reader.PushChunk("C"); | ||
| reader.PushEos(); | ||
|
|
||
| CollectionAssert.AreEqual(new[] { "A", "B", "C" }, Drain(reader)); |
Contributor
Author
There was a problem hiding this comment.
If all chunks arrived in the same frame together with EOS, before the fix the incremental reader would receive EOS and just be marked as done, disregarding the chunks in the queue.
MaxHeimbrock
force-pushed
the
max/datastream-incemental-eos-drain
branch
from
July 20, 2026 14:15
75d1095 to
2c6e789
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When a burst of packages plus the EOS trailer arrived at the same time, the incremental reading of the stream was broken. If the stream was marked EOS, but the queue still had chunks, they were ignored.
This PR adds the logic to fix the bug plus tests.
Changes
What did you do?