Mono audio tracks work in livekit client (tested in unity)#189
Open
davidhughhenrymack wants to merge 1 commit into
Open
Mono audio tracks work in livekit client (tested in unity)#189davidhughhenrymack wants to merge 1 commit into
davidhughhenrymack wants to merge 1 commit into
Conversation
|
|
| var data = new Span<byte>(uFrame.Data.ToPointer(), uFrame.Length); | ||
| _buffer?.Write(data); | ||
| } | ||
| else if (frame.Length > 0 && frame.NumChannels == 1 && _numChannels == 2 && frame.SampleRate == _sampleRate) |
Author
There was a problem hiding this comment.
We need to up-mix from mono to stereo
Contributor
|
Hey David, as you might have seen we have put some work into the Unity SDK since the 1.3.3 release. I just saw your PR today and wanted to check in if you are still working with the SDK and seeing the issue? The audio output is a bit more robust now. I see you also commented on this (GitHub issue)[https://github.com//issues/169], as you can see I was not able to repro. |
Author
|
Thank you! We moved to android :)
… On Jul 17, 2026, at 1:09 AM, Max Heimbrock ***@***.***> wrote:
MaxHeimbrock
left a comment
(livekit/client-sdk-unity#189)
<#189 (comment)>
Hey David, as you might have seen we have put some work into the Unity SDK since the 1.3.3 release. I just saw your PR today and wanted to check in if you are still working with the SDK and seeing the issue? The audio output is a bit more robust now.
There was also this reported GitHub issue, is your issue the same? #169 <#169>
—
Reply to this email directly, view it on GitHub <#189?email_source=notifications&email_token=ADSQKIUIHYD6M7GF2KJ2MR35FHNJ5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBQGA2TCNJUG4Z2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5000515473>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADSQKIT7PZX5WLYTLFL5NMD5FHNJ5AVCNFSNUABFKJSXA33TNF2G64TZHM2TQNJWGA4DQMBWHNEXG43VMU5TGOJZGEZTMNZUGYZKC5QC>.
You are receiving this because you authored the thread.
|
Contributor
|
Hi David,
So this issue only happened on Unity iOS, but it works on Unity Android? I
did not mention the issue being platform specific. Or did you move to the
native LiveKit Android SDK without Unity?
Best regards,
Max
…On Fri, Jul 17, 2026 at 5:20 PM David Mack ***@***.***> wrote:
*davidhughhenrymack* left a comment (livekit/client-sdk-unity#189)
<#189 (comment)>
Thank you! We moved to android :)
> On Jul 17, 2026, at 1:09 AM, Max Heimbrock ***@***.***> wrote:
>
>
> MaxHeimbrock
> left a comment
> (livekit/client-sdk-unity#189)
> <
#189 (comment)>
> Hey David, as you might have seen we have put some work into the Unity
SDK since the 1.3.3 release. I just saw your PR today and wanted to check
in if you are still working with the SDK and seeing the issue? The audio
output is a bit more robust now.
>
> There was also this reported GitHub issue, is your issue the same? #169 <
#169>
> —
> Reply to this email directly, view it on GitHub <
#189?email_source=notifications&email_token=ADSQKIUIHYD6M7GF2KJ2MR35FHNJ5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBQGA2TCNJUG4Z2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5000515473>,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ADSQKIT7PZX5WLYTLFL5NMD5FHNJ5AVCNFSNUABFKJSXA33TNF2G64TZHM2TQNJWGA4DQMBWHNEXG43VMU5TGOJZGEZTMNZUGYZKC5QC>.
> You are receiving this because you authored the thread.
>
—
Reply to this email directly, view it on GitHub
<#189?email_source=notifications&email_token=AKMWRDBLAZ6KXNK46GIRIHD5FI73DA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBQGQ3TIOBTG4Y2M4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5004748371>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKMWRDHCMQNLMDCVG7WTMUD5FI73DAVCNFSNUABFKJSXA33TNF2G64TZHM2TQNJWGA4DQMBWHNEXG43VMU5TGOJZGEZTMNZUGYZKC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AKMWRDEARURTNKSFNYIJ6C35FI73DA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBQGQ3TIOBTG4Y2M4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/AKMWRDBJJ7MVYNWEQGRIUFT5FI73DA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBQGQ3TIOBTG4Y2M4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you commented.Message ID:
***@***.***>
|
| { | ||
| var raw = new Span<byte>(frame.Data.ToPointer(), frame.Length); | ||
| _buffer?.Write(raw); | ||
| } |
Contributor
There was a problem hiding this comment.
How about converting it from stereo to mono ?
As least, I think we should log an error in the else case, and print out the values of all variables, we probably need to handle those use cases gratefully if they happen
Author
|
I've not been tracking since our team moved to android so i cannot answer
this, sorry about that
On Mon, Jul 20, 2026 at 2:03 AM Max Heimbrock ***@***.***>
wrote:
… *MaxHeimbrock* left a comment (livekit/client-sdk-unity#189)
<#189 (comment)>
Hi David,
So this issue only happened on Unity iOS, but it works on Unity Android? I
did not mention the issue being platform specific. Or did you move to the
native LiveKit Android SDK without Unity?
Best regards,
Max
On Fri, Jul 17, 2026 at 5:20 PM David Mack ***@***.***> wrote:
> *davidhughhenrymack* left a comment (livekit/client-sdk-unity#189)
> <
#189 (comment)>
> Thank you! We moved to android :)
>
> > On Jul 17, 2026, at 1:09 AM, Max Heimbrock ***@***.***> wrote:
> >
> >
> > MaxHeimbrock
> > left a comment
> > (livekit/client-sdk-unity#189)
> > <
>
#189 (comment)>
>
> > Hey David, as you might have seen we have put some work into the Unity
> SDK since the 1.3.3 release. I just saw your PR today and wanted to
check
> in if you are still working with the SDK and seeing the issue? The audio
> output is a bit more robust now.
> >
> > There was also this reported GitHub issue, is your issue the same?
#169 <
> #169>
> > —
> > Reply to this email directly, view it on GitHub <
>
#189?email_source=notifications&email_token=ADSQKIUIHYD6M7GF2KJ2MR35FHNJ5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBQGA2TCNJUG4Z2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5000515473>,
> or unsubscribe <
>
https://github.com/notifications/unsubscribe-auth/ADSQKIT7PZX5WLYTLFL5NMD5FHNJ5AVCNFSNUABFKJSXA33TNF2G64TZHM2TQNJWGA4DQMBWHNEXG43VMU5TGOJZGEZTMNZUGYZKC5QC>.
>
> > You are receiving this because you authored the thread.
> >
>
> —
> Reply to this email directly, view it on GitHub
> <
#189?email_source=notifications&email_token=AKMWRDBLAZ6KXNK46GIRIHD5FI73DA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBQGQ3TIOBTG4Y2M4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5004748371>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AKMWRDHCMQNLMDCVG7WTMUD5FI73DAVCNFSNUABFKJSXA33TNF2G64TZHM2TQNJWGA4DQMBWHNEXG43VMU5TGOJZGEZTMNZUGYZKC5QC>
> .
> Triage notifications, keep track of coding agent tasks and review pull
> requests on the go with GitHub Mobile for iOS
> <
https://github.com/notifications/mobile/ios/AKMWRDEARURTNKSFNYIJ6C35FI73DA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBQGQ3TIOBTG4Y2M4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJKTGN5XXIZLSL5UW64Y>
> and Android
> <
https://github.com/notifications/mobile/android/AKMWRDBJJ7MVYNWEQGRIUFT5FI73DA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBQGQ3TIOBTG4Y2M4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
> Download it today!
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#189?email_source=notifications&email_token=ADSQKIWLUF333CLIJSFENYL5FXN6ZA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBSGA2TAMBXHEZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5020500792>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADSQKIQLWUEDEVW3T3ZJMIT5FXN6ZAVCNFSNUABFKJSXA33TNF2G64TZHM2TQNJWGA4DQMBWHNEXG43VMU5TGOJZGEZTMNZUGYZKC5QC>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please merge so i don't have to keep a fork :)