Repository navigation
fix: accept bare NR3 responses on legacy dialect voltage/timebase/rate queries - #178
Merged
little-did-I-know merged 1 commit intoSep 14, 2026
Merged
Conversation
…e queries A real SDS1104X-E returns "1.00E+00" (no unit suffix) for C1:VDIV? instead of the RC01020-E01C-documented "1.00E+00V", which made get_waveform() raise CommandError. Legacy was deliberately excluded from BARE_NR3_DIALECTS on the assumption it always echoes a unit; that assumption doesn't hold on real hardware. Legacy now joins the same bare-NR3 fallback already used for modern/Tektronix/LeCroy, while the unit-suffixed check still runs first for compliant responses. Fixes #177
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
little-did-I-know
deleted the
fix/legacy-dialect-bare-nr3-voltage-scale
branch
September 14, 2026 16:14
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
C1:VDIV?(e.g."1.00E+00"instead of the RC01020-E01C-documented"1.00E+00V"), which madeget_waveform()raiseCommandError: Invalid voltage scale response.legacySiglent dialect was deliberately excluded fromBARE_NR3_DIALECTSon the assumption it always echoes a unit. This bug report disproves that assumption on real hardware.legacynow joins the same bare-NR3 fallback already used formodern/tektronix/lecroy(scpi_control/scpi_commands.py), so_parse_value_with_unitsaccepts a bare float forC1:VDIV?,C1:OFST?,TDIV?, andSARA?when no unit suffix is present, while the documented unit-suffixed format still parses via the primary check first.test_bare_nr3_dialectsandtest_value_parsing_requires_units(repurposed to verify genuinely unparseable responses still raise).Fixes #177
Test plan
test_legacy_dialect_accepts_bare_nr3_without_unitsfails against pre-fix code, passes after the fixpytest tests/test_waveform_parsing.py tests/test_scpi_command_tables.py tests/test_mock_dialects.py -v— 116 passedpytest -m "not slow" -n 8— 3015 passed, 61 skipped, no regressionsCHANGELOG.md/docs/about/changelog.mdmirror verified in sync