Skip to content

26 urllibclient does not send empty json object #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
litteratum merged 2 commits into from
Mar 14, 2026
Merged

26 urllibclient does not send empty json object #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b4c850
26: UrlibHTTPClient - fix handling of json={}
litteratum Mar 14, 2026
fcf6901
26: update dependencies; drop Python 3.9 support
litteratum Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ lint:
flake8 $(PACKAGE) tests
pylint --rcfile=pyproject.toml $(PACKAGE) tests
mypy $(PACKAGE) tests
pip-audit
pip-audit -l

.PHONY: testall
testall: lint test
Expand Down
2 changes: 1 addition & 1 deletion httprest/http/urllib_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def _request(
data = urllib.parse.urlencode(data).encode() # type: ignore
headers["Content-Type"] = "application/x-www-form-urlencoded"

if json:
if json is not None:
headers["Content-Type"] = "application/json"
data = _jsonlib.dumps(json).encode()

Expand Down
2 changes: 1 addition & 1 deletion noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import nox


@nox.session(python=["3.9", "3.11", "3.12", "3.13", "3.14"])
@nox.session(python=["3.11", "3.12", "3.13", "3.14"])
def tests(session):
"""Run tests."""
session.run("make", "testdeps", external=True)
Expand Down
Loading
Loading