feat: enable memory profiling#1927
Merged
Merged
Conversation
Signed-off-by: anilb <epipav@gmail.com>
Signed-off-by: anilb <epipav@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Enables Node.js heap snapshotting in the frontend production container to support memory profiling / investigation of high-memory conditions.
Changes:
- Adds a
/app/heapdumpsdirectory intended to persist heap snapshots. - Updates the runtime command to enable
--heapsnapshot-near-heap-limitand--heapsnapshot-signal=SIGUSR2. - Changes the container working directory to
/app/heapdumpsso snapshots are written there by default.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: anilb <epipav@gmail.com>
Collaborator
Author
|
@copilot review |
Contributor
epipav
force-pushed
the
tmp/enable-memory-profiling
branch
from
07c7aa2 to
1aa0e99
Compare
Signed-off-by: anilb <epipav@gmail.com>
Signed-off-by: anilb <epipav@gmail.com>
Signed-off-by: anilb <epipav@gmail.com>
Comment on lines
84
to
+87
| chown -R nuxt:nodejs /app | ||
|
|
||
| RUN mkdir -p /app/heapdumps && chown nuxt:nodejs /app/heapdumps | ||
|
|
Comment on lines
+95
to
+97
| # When enabled, cd into the heapdumps volume mount so snapshots land there. | ||
| # exec replaces sh with node for proper signal handling. | ||
| CMD ["/bin/sh", "-c", "if [ \"$HEAP_SNAPSHOT_ENABLED\" = \"1\" ] || [ \"$HEAP_SNAPSHOT_ENABLED\" = \"true\" ]; then cd /app/heapdumps && exec node --heapsnapshot-near-heap-limit=3 --heapsnapshot-signal=SIGUSR2 /app/.output/server/index.mjs; else exec node /app/.output/server/index.mjs; fi"] |
Comment on lines
+94
to
+97
| # Heap snapshots are opt-in: set HEAP_SNAPSHOT_ENABLED=1 to activate. | ||
| # When enabled, cd into the heapdumps volume mount so snapshots land there. | ||
| # exec replaces sh with node for proper signal handling. | ||
| CMD ["/bin/sh", "-c", "if [ \"$HEAP_SNAPSHOT_ENABLED\" = \"1\" ] || [ \"$HEAP_SNAPSHOT_ENABLED\" = \"true\" ]; then cd /app/heapdumps && exec node --heapsnapshot-near-heap-limit=3 --heapsnapshot-signal=SIGUSR2 /app/.output/server/index.mjs; else exec node /app/.output/server/index.mjs; fi"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.