fix: remove white border on icon hover state#590
Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom Mar 23, 2026
Merged
fix: remove white border on icon hover state#590deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
Conversation
Removed the hover state effect that was adding lightness to icons, which caused a white border appearance during hover interactions. The hover state modification was removed while keeping the pressed state effect (lightness -10) intact. This change ensures icons maintain consistent visual appearance across different interaction states without unintended visual artifacts. Log: Fixed icon hover state displaying white border issue Influence: 1. Test icon hover interactions to verify no white border appears 2. Verify pressed state still shows appropriate visual feedback (darker appearance) 3. Check icon rendering consistency across different themes and sizes 4. Test with various icon types to ensure no regressions in visual quality fix: 修复图标悬停状态显示白边问题 移除了图标悬停状态添加亮度的效果,该效果导致悬停交互时出现白边外观。悬停 状态修改已被移除,同时保持按下状态效果(亮度-10)不变。此更改确保图标在 不同交互状态下保持一致的视觉外观,不会出现意外的视觉伪影。 Log: 修复图标悬停状态显示白边问题 Influence: 1. 测试图标悬停交互,验证是否出现白边 2. 验证按下状态是否仍显示适当的视觉反馈(变暗效果) 3. 检查不同主题和尺寸下的图标渲染一致性 4. 测试多种图标类型,确保视觉质量没有回归 PMS: BUG-310087 Change-Id: Id3c2634ba1373c7e26061e2906ef1563801a9bb6
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves the lightening effect applied to icons in Hover mode while preserving the darkening effect in Pressed mode, ensuring icon visuals remain unchanged on hover and still provide feedback when pressed. Flow diagram for generateDciIconImage mode handling after fixflowchart TD
A["generateDciIconImage called"] --> B["Initialize hue, saturation, lightness, red, green, blue, alpha to 0"]
B --> C{mode}
C -->|DDciIcon_Pressed| D["lightness -= 10"]
C -->|DDciIcon_Hover_or_other| E["return src"]
D --> F["Apply adjustments and return modified image"]
E --> G["Return original src image"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
18202781743
approved these changes
Mar 23, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, xionglinlin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
Contributor
|
This pr force merged! (status: unstable) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the hover state effect that was adding lightness to icons, which caused a white border appearance during hover interactions. The hover state modification was removed while keeping the pressed state effect (lightness -10) intact. This change ensures icons maintain consistent visual appearance across different interaction states without unintended visual artifacts.
Log: Fixed icon hover state displaying white border issue
Influence:
fix: 修复图标悬停状态显示白边问题
移除了图标悬停状态添加亮度的效果,该效果导致悬停交互时出现白边外观。悬停
状态修改已被移除,同时保持按下状态效果(亮度-10)不变。此更改确保图标在
不同交互状态下保持一致的视觉外观,不会出现意外的视觉伪影。
Log: 修复图标悬停状态显示白边问题
Influence:
PMS: BUG-310087
Change-Id: Id3c2634ba1373c7e26061e2906ef1563801a9bb6
Summary by Sourcery
Adjust icon interaction rendering to remove unintended hover lightening effect while preserving pressed state feedback.
Bug Fixes:
Enhancements: