Skip to content

chore: update version to 6.5.38#196

Merged
wyu71 merged 1 commit intolinuxdeepin:develop/snipefrom
wyu71:develop/snipe
Mar 12, 2026
Merged

chore: update version to 6.5.38#196
wyu71 merged 1 commit intolinuxdeepin:develop/snipefrom
wyu71:develop/snipe

Conversation

@wyu71
Copy link
Contributor

@wyu71 wyu71 commented Mar 12, 2026

  • bump version to 6.5.38

Log : bump version to 6.5.38

Summary by Sourcery

Enhancements:

  • Align package configuration with the new 6.5.38.1 release version.

- bump version to 6.5.38

Log : bump version to 6.5.38
@github-actions
Copy link

TAG Bot

TAG: 6.5.38
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 12, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates application/package metadata to bump the deepin-draw version from 6.5.37.1 to 6.5.38.1 for the linglong package and Debian packaging configuration.

File-Level Changes

Change Details Files
Bump application/package version to 6.5.38.1 in build/packaging metadata.
  • Update the linglong package manifest version field to 6.5.38.1.
  • Adjust corresponding Debian packaging changelog entry to reflect the 6.5.38 release.
linglong.yaml
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

deepin pr auto review

这份 git diff 包含了两个文件的变更:debian/changeloglinglong.yaml,主要目的是发布新版本 6.5.38。以下是对这些变更的审查意见:

1. 语法与逻辑审查

  • debian/changelog:
    • 格式规范:符合 Debian 的 changelog 格式标准(dpkg-parsechangelog 可解析)。
    • 版本号:版本号从 6.5.37 升级到 6.5.38,符合语义化版本控制逻辑(次版本号递增)。
    • 日期异常:提交记录中的日期显示为 2026年3月12日
      • 严重问题:除非这是针对未来的长期计划提交,否则系统时间设置有误。错误的日期可能会导致包管理工具(如 dch 或构建系统)在排序或生成发布元数据时出现逻辑错误,或者导致用户困惑。
  • linglong.yaml:
    • 版本号:版本号从 6.5.37.1 变更为 6.5.38.1
    • 逻辑一致性:这里的版本号规则似乎是 {主版本号}.{修订版本号}.{构建号}。变更与 changelog 中的主版本号变更保持了一致。

2. 代码质量

  • Commit Message 规范性
    • changelog 中的条目 fix(ctextedit): fix crash and Qt6 deprecated API usage 写得比较规范,使用了常见的 type(scope): description 格式。它清晰地指出了修改的模块(ctextedit)、修复的问题(崩溃)以及技术债务处理(Qt6 废弃 API)。
  • 文件完整性
    • Diff 仅展示了元数据文件的变更。虽然 changelog 声称修复了崩溃和废弃 API,但没有展示实际的源代码变更。因此,无法评估针对 "crash" 或 "Qt6 deprecated API" 的修复质量。

3. 代码性能

  • 由于没有提供源代码(.cpp, .h 等)的变更,无法评估本次更新对程序运行时性能的具体影响。

4. 代码安全

  • 崩溃修复changelog 提到了 "fix crash"。修复崩溃通常与安全相关(如防止空指针解引用、缓冲区溢出等)。虽然无法审查具体代码,但修复崩溃是提升安全性的积极信号。
  • Qt6 迁移:更新到 Qt6 的新 API 通常会带来安全性和性能上的提升,因为 Qt6 修复了许多旧版本的底层问题。

改进建议

  1. 修正日期错误(高优先级)
    请检查并修正 debian/changelog 中的日期。当前日期 Thu, 12 Mar 2026 是未来的时间。应将其设置为当前的实际提交日期(例如 20232024 年)。

    • 示例修正-- Wang Yu <wangyu@uniontech.com> Thu, 12 Mar 2024 20:42:32 +0800
  2. 同步源代码 Diff
    为了全面审查 "fix crash" 和 "Qt6 deprecated API usage" 的有效性,请提供 src/ 或相关目录下涉及 ctextedit 的源代码变更 Diff。

  3. 版本号一致性检查
    请确认 debian/changelog 中的版本号 6.5.38linglong.yaml 中的 6.5.38.1 在打包流程中的映射关系是否符合预期。通常 Linglong 的构建版本号后缀(.1)用于区分构建迭代,需确保构建系统正确解析了基础版本号 6.5.38

总结:元数据文件的格式基本正确,但日期存在严重错误,必须修正。若要评估代码质量和安全性,需要补充具体的源代码变更内容。

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@wyu71 wyu71 merged commit b52ae6d into linuxdeepin:develop/snipe Mar 12, 2026
20 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, wyu71

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Mar 12, 2026

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.5.38
  • Tag SHA: 0d15b3d3234553da5835fea43654f9fa05855c33
  • Commit SHA: aa0153d38364f6746396f0298e2d0e549636ef8f
  • Tag Message:
    Release deepin-draw 6.5.38
    
    
  • Tagger:
    • Name: wyu71
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants