feat: refactor SNI tray initialization to use thread pool#439
Merged
18202781743 merged 1 commit intolinuxdeepin:masterfrom Mar 11, 2026
Merged
feat: refactor SNI tray initialization to use thread pool#43918202781743 merged 1 commit intolinuxdeepin:masterfrom
18202781743 merged 1 commit intolinuxdeepin:masterfrom
Conversation
1. Changed SNI tray item initialization from synchronous to asynchronous using QThreadPool 2. Added pending items tracking to handle concurrent creation and cancellation 3. Delayed QLabel creation for tooltip to ensure proper thread context 4. Set DBus timeout to 2000ms to prevent blocking 5. Removed async DBus calls that caused data inconsistency issues Log: Improved application tray startup performance and stability Influence: 1. Test tray icon loading with multiple applications simultaneously 2. Verify tray icons appear correctly without delays or missing icons 3. Test tooltip display functionality for SNI tray items 4. Verify tray removal when applications close 5. Test concurrent tray item addition and removal scenarios 6. Check memory usage during rapid tray updates 7. Verify no DBus-related crashes or data inconsistencies feat: 重构SNI托盘初始化改用线程池 1. 将SNI托盘项初始化从同步改为异步，使用QThreadPool 2. 添加待处理项跟踪以处理并发创建和取消 3. 延迟创建QLabel工具提示，确保正确的线程上下文 4. 设置DBus超时为2000ms以防止阻塞 5. 移除导致数据不一致问题的异步DBus调用 Log: 提升应用托盘启动性能和稳定性 Influence: 1. 测试同时加载多个应用程序时的托盘图标 2. 验证托盘图标正确显示，无延迟或缺失图标 3. 测试SNI托盘项的工具提示显示功能 4. 验证应用程序关闭时托盘项正确移除 5. 测试并发托盘项添加和移除场景 6. 检查快速托盘更新时的内存使用情况 7. 验证无DBus相关崩溃或数据不一致问题 PMS: BUG-351735 BUG-351739
18202781743
requested review from
BLumia,
fly602,
mhduiy,
robertkill,
wjyrich and
yixinshark
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @18202781743, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
BLumia
approved these changes
Mar 11, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using QThreadPool
cancellation
Log: Improved application tray startup performance and stability
Influence:
feat: 重构SNI托盘初始化改用线程池
Log: 提升应用托盘启动性能和稳定性
Influence:
PMS: BUG-351735 BUG-351739