fix: adjust dock network widget height calculation#529
Open
wjyrich wants to merge 1 commit intolinuxdeepin:masterfrom
Open
fix: adjust dock network widget height calculation#529wjyrich wants to merge 1 commit intolinuxdeepin:masterfrom
wjyrich wants to merge 1 commit intolinuxdeepin:masterfrom
Conversation
The height calculation for the dock network widget was incorrect, causing the widget to be too short when the network check button is visible. The issue was that the calculation didn't include enough padding at the bottom of the widget, resulting in UI elements being cut off or too close to the edge. The fix adds an extra 20 pixels to the total height calculation when setting the fixed size. This ensures proper spacing between the network view content and the bottom of the widget container, especially when the network check button is displayed. Log: Fixed dock network panel height issue where content was too close to bottom edge Influence: 1. Test dock network widget display with network check button visible 2. Verify widget height is sufficient to show all content without clipping 3. Check spacing between network view and widget boundaries 4. Test both scenarios: with and without network check button visible 5. Verify overall dock panel layout remains consistent fix: 调整任务栏网络插件高度计算 任务栏网络插件的高度计算存在错误，导致网络检查按钮可见时插件高度过小。问 题在于计算底部填充不足，导致UI元素被截断或过于靠近边缘。 修复方法是在设置固定大小时，在总高度计算中添加额外的20像素。这确保了网络 视图内容与插件容器底部之间有适当的间距，特别是在网络检查按钮显示时。 Log: 修复了任务栏网络面板高度问题，解决了内容过于靠近底部边缘的情况 Influence: 1. 测试网络检查按钮可见时的任务栏网络插件显示 2. 验证插件高度是否足够显示所有内容而不被裁剪 3. 检查网络视图与插件边界之间的间距 4. 测试两种场景：网络检查按钮可见和不可见 5. 验证整体任务栏面板布局保持一致性
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The height calculation for the dock network widget was incorrect, causing the widget to be too short when the network check button is visible. The issue was that the calculation didn't include enough padding at the bottom of the widget, resulting in UI elements being cut off or too close to the edge.
The fix adds an extra 20 pixels to the total height calculation when setting the fixed size. This ensures proper spacing between the network view content and the bottom of the widget container, especially when the network check button is displayed.
Log: Fixed dock network panel height issue where content was too close to bottom edge
Influence:
fix: 调整任务栏网络插件高度计算
任务栏网络插件的高度计算存在错误，导致网络检查按钮可见时插件高度过小。问
题在于计算底部填充不足，导致UI元素被截断或过于靠近边缘。
修复方法是在设置固定大小时，在总高度计算中添加额外的20像素。这确保了网络
视图内容与插件容器底部之间有适当的间距，特别是在网络检查按钮显示时。
Log: 修复了任务栏网络面板高度问题，解决了内容过于靠近底部边缘的情况
Influence:
PMS: BUG-353585