Skip to content

[PW_SID:1067129] riscv: support EIC770X/JH7110 noncoherent devices with XPbmtUC#1618

Open
linux-riscv-bot wants to merge 3 commits intoworkflow__riscv__fixesfrom
pw1067129
Open

[PW_SID:1067129] riscv: support EIC770X/JH7110 noncoherent devices with XPbmtUC#1618
linux-riscv-bot wants to merge 3 commits intoworkflow__riscv__fixesfrom
pw1067129

Conversation

@linux-riscv-bot
Copy link

PR for series 1067129 applied to workflow__riscv__fixes

Name: riscv: support EIC770X/JH7110 noncoherent devices with XPbmtUC
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1067129
Version: 2

Previously only auipc+jalr pair is supported. Add auipc+load pair
to support PC-relative memory load instruction as well.

Signed-off-by: Bo Gan <ganboing@gmail.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Enhance the errata/sifive patching function to support auipc/load
insn pair by fixing the offsets in immediate, just like in function
`riscv_cpufeature_patch_func`. Refer to commit 27c653c
("RISC-V: fix auipc-jalr addresses in patched alternatives")

Signed-off-by: Bo Gan <ganboing@gmail.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
…thout

On some platforms with pre-Svpbmt Sifive cores, they map the system
memory twice in physical address space, one as cached (through the
front port), and the other as uncached (through the system port), to
enable drivers working with non-cache-coherent devices. Drivers can map
the DMA buffers uncached through the uncached alias, and don't have to
flush caches explicitly. It eases the driver programming. For complex
device drivers, such as the GPU, this is a must have, as DMA pages can
be mmap'ed to user space, and the userspace can't do caches flushes due
to the lack of Zicbom on these older cores.

Introduce a Sifive "errata" to model such setup with a customized
version of Svpbmt, "XPbmtUC", where a single, artificial bit in the PTE
is used for cache/uncache control (UC), effectively offsetting the PPN
by power-of-2. I.e.,

Starfive JH7110 (Sifive U74):
           [0x0,   0x40000000) Low MMIO
    [0x40000000, 0x2_40000000) Cached Mem
  [0x4_40000000, 0x6_40000000) Uncached Mem UC+
  [0x9_00000000, 0x9_d0000000) High MMIO

Using PTE bit 32 (PPN bit 34) as UC (uncache) control perfectly matches
the memory map of the SoC.

Other SoCs like ESWIN EIC770X is not directly compatible to this model,
as the uncached regions are not power-of-2 offseted, and the offsets are
different between Dies in the dual-die version (EIC7702). The firmware,
however, could use G-stage page table to transparently re-map, and make
the address space suitable for XPbmtUC scheme to be applied:

             [0x0,     0x20000000) Core Internal
      [0x20000000,     0x40000000) Core Internal (Die 1)
      [0x40000000,     0x60000000) Low MMIO
      [0x60000000,     0x80000000) Low MMIO (Die 1)
      [0x80000000,  0x10_80000000) Cached Mem
   [0x20_00000000,  0x30_00000000) Cached Mem (Die 1)
   [0x80_00000000,  0xa0_00000000) High MMIO
   [0xa0_00000000,  0xc0_00000000) High MMIO (Die 1)
   [0xc0_00000000,  0xd0_00000000) Uncached Mem <----------.
   [0xe0_00000000,  0xf0_00000000) Uncached Mem (Die 1) <--+--.
 with firmware/hypervisor re-mapping:                      |  |
 ------------------------------------                      |  |
  [0x100_80000000, 0x110_80000000) Mem UC+ ----------------'  |
  [0x120_00000000, 0x130_00000000) Mem UC+ (Die 1) -----------'

Such firmware capability is detected at boot time by sbi ecalls. The
firmware will provide us the UC bit position if re-map is in effect.

Note: currently this feature is gated by JH7110 and EIC770X SoCs to
avoid unnecessary sbi ecalls. There's also no IO bit in such XPbmtUC
scheme, as it's assumed that the PMA (hard-wired on these SoCs) will
convey the strongly-ordered, non-idempotent attribute of MMIO regions.

Signed-off-by: Bo Gan <ganboing@gmail.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,v2,1/3] riscv: alternatives: support auipc+load pair"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 136.42 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,v2,1/3] riscv: alternatives: support auipc+load pair"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1139.74 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,v2,1/3] riscv: alternatives: support auipc+load pair"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1667.34 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,v2,1/3] riscv: alternatives: support auipc+load pair"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.66 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,v2,1/3] riscv: alternatives: support auipc+load pair"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 28.16 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,v2,1/3] riscv: alternatives: support auipc+load pair"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.18 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,v2,1/3] riscv: alternatives: support auipc+load pair"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 83.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,v2,1/3] riscv: alternatives: support auipc+load pair"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,v2,1/3] riscv: alternatives: support auipc+load pair"
kdoc
Desc: Detects for kdoc errors
Duration: 0.88 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,v2,1/3] riscv: alternatives: support auipc+load pair"
module-param
Desc: Detect module_param changes
Duration: 0.64 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,v2,1/3] riscv: alternatives: support auipc+load pair"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[RFC,v2,1/3] riscv: alternatives: support auipc+load pair"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,v2,2/3] riscv: errata: sifive: support auipc/load pair in patched alternatives"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 139.29 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,v2,2/3] riscv: errata: sifive: support auipc/load pair in patched alternatives"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1127.36 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,v2,2/3] riscv: errata: sifive: support auipc/load pair in patched alternatives"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1650.38 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,v2,2/3] riscv: errata: sifive: support auipc/load pair in patched alternatives"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 27.00 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,v2,2/3] riscv: errata: sifive: support auipc/load pair in patched alternatives"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 28.04 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,v2,2/3] riscv: errata: sifive: support auipc/load pair in patched alternatives"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.74 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,v2,2/3] riscv: errata: sifive: support auipc/load pair in patched alternatives"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 82.17 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,v2,2/3] riscv: errata: sifive: support auipc/load pair in patched alternatives"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,v2,2/3] riscv: errata: sifive: support auipc/load pair in patched alternatives"
kdoc
Desc: Detects for kdoc errors
Duration: 0.86 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,v2,2/3] riscv: errata: sifive: support auipc/load pair in patched alternatives"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,v2,2/3] riscv: errata: sifive: support auipc/load pair in patched alternatives"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.21 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[RFC,v2,2/3] riscv: errata: sifive: support auipc/load pair in patched alternatives"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,v2,3/3] riscv: errata: sifive: Add an "errata" to simulate Svpbmt on cores without"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 138.19 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,v2,3/3] riscv: errata: sifive: Add an "errata" to simulate Svpbmt on cores without"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 25.17 seconds
Result: ERROR
Output:

Redirect to /build/tmp.96PRk54g39 and /build/tmp.IiyZZuMxCd
Tree base:
62b889c3621a8 ("riscv: errata: sifive: support auipc/load pair in patched alternatives")
Building the whole tree with the patch
error:
/build/tmpozts85f0/arch/riscv/include/asm/pgtable-64.h:154:2: error: expected string literal in 'asm'
/build/tmpozts85f0/arch/riscv/include/asm/pgtable-64.h:162:2: error: expected string literal in 'asm'
/build/tmpozts85f0/arch/riscv/include/asm/pgtable-64.h:170:2: error: expected string literal in 'asm'



real	0m23.858s
user	0m15.360s
sys	0m27.184s

@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,v2,3/3] riscv: errata: sifive: Add an "errata" to simulate Svpbmt on cores without"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 22.64 seconds
Result: ERROR
Output:

Redirect to /build/tmp.psW8D0JoKZ and /build/tmp.DtzAgZWHzR
Tree base:
62b889c3621a8 ("riscv: errata: sifive: support auipc/load pair in patched alternatives")
Building the whole tree with the patch
error:
/build/tmpozts85f0/arch/riscv/include/asm/errata_list.h:75:5: error: expected string literal before 'ALTERNATIVE_3'
/build/tmpozts85f0/arch/riscv/include/asm/errata_list.h:75:5: error: expected string literal before 'ALTERNATIVE_3'
/build/tmpozts85f0/arch/riscv/include/asm/errata_list.h:75:5: error: expected string literal before 'ALTERNATIVE_3'



real	0m21.214s
user	0m22.207s
sys	0m22.673s

@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,v2,3/3] riscv: errata: sifive: Add an "errata" to simulate Svpbmt on cores without"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 12.75 seconds
Result: ERROR
Output:

Full log:
W: Support for running offline not available (unshare: unshare failed: Operation not permitted)
I: config: PASS in 0:00:04.634278
I: default: FAIL in 0:00:02.387963
I: kernel: SKIP in 0:00:00.000009
I: xipkernel: SKIP in 0:00:00.000004
I: modules: SKIP in 0:00:00.003149
I: dtbs: PASS in 0:00:01.571297
I: dtbs-legacy: SKIP in 0:00:00.003659
I: debugkernel: SKIP in 0:00:00.000004
I: headers: PASS in 0:00:01.144528
I: build output in /build/tmp.c7Ipp9WY0K
tuxmake --download-all-korg-gcc-toolchains --target-arch=riscv --kconfig=nommu_k210_defconfig --toolchain=gcc --wrapper=ccache --environment=KBUILD_BUILD_TIMESTAMP=@1621270510 --environment=KBUILD_BUILD_USER=tuxmake --environment=KBUILD_BUILD_HOST=tuxmake --environment=KCFLAGS=-ffile-prefix-map=/build/tmp.c7Ipp9WY0K/build/= --runtime=null --image=docker.io/tuxmake/riscv_gcc CROSS_COMPILE=riscv64-linux- config default kernel xipkernel modules dtbs dtbs-legacy debugkernel headers
make --silent --keep-going --jobs=48 O=/build/tmp.c7Ipp9WY0K/build ARCH=riscv CROSS_COMPILE=riscv64-linux- 'CC=ccache riscv64-linux-gcc' 'HOSTCC=ccache gcc' nommu_k210_defconfig
make --silent --keep-going --jobs=48 O=/build/tmp.c7Ipp9WY0K/build ARCH=riscv CROSS_COMPILE=riscv64-linux- 'CC=ccache riscv64-linux-gcc' 'HOSTCC=ccache gcc'
In file included from /build/tmpozts85f0/arch/riscv/include/asm/vdso/processor.h:8,
                 from /build/tmpozts85f0/include/vdso/processor.h:10,
                 from /build/tmpozts85f0/arch/riscv/include/asm/processor.h:13,
                 from /build/tmpozts85f0/arch/riscv/include/asm/cmpxchg.h:16,
                 from /build/tmpozts85f0/arch/riscv/include/asm/barrier.h:14,
                 from /build/tmpozts85f0/include/asm-generic/bitops/generic-non-atomic.h:7,
                 from /build/tmpozts85f0/include/linux/bitops.h:28,
                 from /build/tmpozts85f0/include/linux/thread_info.h:27,
                 from /build/tmpozts85f0/include/asm-generic/preempt.h:5,
                 from ./arch/riscv/include/generated/asm/preempt.h:1,
                 from /build/tmpozts85f0/include/linux/preempt.h:79,
                 from /build/tmpozts85f0/include/linux/spinlock.h:56,
                 from /build/tmpozts85f0/include/linux/mmzone.h:8,
                 from /build/tmpozts85f0/include/linux/gfp.h:7,
                 from /build/tmpozts85f0/include/linux/mm.h:7,
                 from /build/tmpozts85f0/arch/riscv/kernel/asm-offsets.c:9:
/build/tmpozts85f0/arch/riscv/include/asm/pgtable-64.h: In function 'riscv_page_mtmask':
/build/tmpozts85f0/arch/riscv/include/asm/errata_list.h:75:5: error: expected string literal before 'ALTERNATIVE_3'
   75 | asm(ALTERNATIVE_3("li %0, 0\t\nnop",                                    \
      |     ^~~~~~~~~~~~~
/build/tmpozts85f0/arch/riscv/include/asm/pgtable-64.h:154:9: note: in expansion of macro 'ALT_SVPBMT'
  154 |         ALT_SVPBMT(val, _PAGE_MTMASK);
      |         ^~~~~~~~~~
/build/tmpozts85f0/arch/riscv/include/asm/pgtable-64.h: In function 'riscv_page_nocache':
/build/tmpozts85f0/arch/riscv/include/asm/errata_list.h:75:5: error: expected string literal before 'ALTERNATIVE_3'
   75 | asm(ALTERNATIVE_3("li %0, 0\t\nnop",                                    \
      |     ^~~~~~~~~~~~~
/build/tmpozts85f0/arch/riscv/include/asm/pgtable-64.h:162:9: note: in expansion of macro 'ALT_SVPBMT'
  162 |         ALT_SVPBMT(val, _PAGE_NOCACHE);
      |         ^~~~~~~~~~
/build/tmpozts85f0/arch/riscv/include/asm/pgtable-64.h: In function 'riscv_page_io':
/build/tmpozts85f0/arch/riscv/include/asm/errata_list.h:75:5: error: expected string literal before 'ALTERNATIVE_3'
   75 | asm(ALTERNATIVE_3("li %0, 0\t\nnop",                                    \
      |     ^~~~~~~~~~~~~
/build/tmpozts85f0/arch/riscv/include/asm/pgtable-64.h:170:9: note: in expansion of macro 'ALT_SVPBMT'
  170 |         ALT_SVPBMT(val, _PAGE_IO);
      |         ^~~~~~~~~~
make[3]: *** [/build/tmpozts85f0/scripts/Makefile.build:184: arch/riscv/kernel/asm-offsets.s] Error 1
make[3]: Target 'prepare' not remade because of errors.
make[2]: *** [/build/tmpozts85f0/Makefile:1333: prepare0] Error 2
make[2]: Target '__all' not remade because of errors.
make[1]: *** [/build/tmpozts85f0/Makefile:248: __sub-make] Error 2
make[1]: Target '__all' not remade because of errors.
make: *** [Makefile:248: __sub-make] Error 2
make: Target '__all' not remade because of errors.
make --silent --keep-going --jobs=48 O=/build/tmp.c7Ipp9WY0K/build INSTALL_DTBS_PATH=/build/tmp.c7Ipp9WY0K/build/dtbsinstall/dtbs ARCH=riscv CROSS_COMPILE=riscv64-linux- 'CC=ccache riscv64-linux-gcc' 'HOSTCC=ccache gcc' dtbs
rm -rf /build/tmp.c7Ipp9WY0K/build/dtbsinstall
mkdir -p /build/tmp.c7Ipp9WY0K/build/dtbsinstall/dtbs
make --silent --keep-going --jobs=48 O=/build/tmp.c7Ipp9WY0K/build INSTALL_DTBS_PATH=/build/tmp.c7Ipp9WY0K/build/dtbsinstall/dtbs ARCH=riscv CROSS_COMPILE=riscv64-linux- 'CC=ccache riscv64-linux-gcc' 'HOSTCC=ccache gcc' dtbs_install
tar --sort=name --owner=tuxmake:1000 --group=tuxmake:1000 --mtime=@1773641498 --clamp-mtime -caf /build/tmp.c7Ipp9WY0K/build/dtbs.tar -C /build/tmp.c7Ipp9WY0K/build/dtbsinstall dtbs
rm -rf /build/tmp.c7Ipp9WY0K/build/install_hdr
make --silent --keep-going --jobs=48 O=/build/tmp.c7Ipp9WY0K/build INSTALL_HDR_PATH=/build/tmp.c7Ipp9WY0K/build/install_hdr/ ARCH=riscv CROSS_COMPILE=riscv64-linux- 'CC=ccache riscv64-linux-gcc' 'HOSTCC=ccache gcc' headers_install
tar --sort=name --owner=tuxmake:1000 --group=tuxmake:1000 --mtime=@1773641498 --clamp-mtime -caf /build/tmp.c7Ipp9WY0K/build/headers.tar -C /build/tmp.c7Ipp9WY0K/build/install_hdr .
warnings/errors:
/build/tmpozts85f0/arch/riscv/include/asm/errata_list.h:75:5: error: expected string literal before 'ALTERNATIVE_3'
/build/tmpozts85f0/arch/riscv/include/asm/errata_list.h:75:5: error: expected string literal before 'ALTERNATIVE_3'
/build/tmpozts85f0/arch/riscv/include/asm/errata_list.h:75:5: error: expected string literal before 'ALTERNATIVE_3'


@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,v2,3/3] riscv: errata: sifive: Add an "errata" to simulate Svpbmt on cores without"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 12.48 seconds
Result: ERROR
Output:

Full log:
W: Support for running offline not available (unshare: unshare failed: Operation not permitted)
I: config: PASS in 0:00:04.359802
I: default: FAIL in 0:00:02.368836
I: kernel: SKIP in 0:00:00.000008
I: xipkernel: SKIP in 0:00:00.000005
I: modules: SKIP in 0:00:00.001875
I: dtbs: PASS in 0:00:01.527689
I: dtbs-legacy: SKIP in 0:00:00.004707
I: debugkernel: SKIP in 0:00:00.000004
I: headers: PASS in 0:00:01.176546
I: build output in /build/tmp.Kz9P4XAuHf
tuxmake --download-all-korg-gcc-toolchains --target-arch=riscv --kconfig=nommu_virt_defconfig --toolchain=gcc --wrapper=ccache --environment=KBUILD_BUILD_TIMESTAMP=@1621270510 --environment=KBUILD_BUILD_USER=tuxmake --environment=KBUILD_BUILD_HOST=tuxmake --environment=KCFLAGS=-ffile-prefix-map=/build/tmp.Kz9P4XAuHf/build/= --runtime=null --image=docker.io/tuxmake/riscv_gcc CROSS_COMPILE=riscv64-linux- config default kernel xipkernel modules dtbs dtbs-legacy debugkernel headers
make --silent --keep-going --jobs=48 O=/build/tmp.Kz9P4XAuHf/build ARCH=riscv CROSS_COMPILE=riscv64-linux- 'CC=ccache riscv64-linux-gcc' 'HOSTCC=ccache gcc' nommu_virt_defconfig
make --silent --keep-going --jobs=48 O=/build/tmp.Kz9P4XAuHf/build ARCH=riscv CROSS_COMPILE=riscv64-linux- 'CC=ccache riscv64-linux-gcc' 'HOSTCC=ccache gcc'
In file included from /build/tmpozts85f0/arch/riscv/include/asm/vdso/processor.h:8,
                 from /build/tmpozts85f0/include/vdso/processor.h:10,
                 from /build/tmpozts85f0/arch/riscv/include/asm/processor.h:13,
                 from /build/tmpozts85f0/arch/riscv/include/asm/cmpxchg.h:16,
                 from /build/tmpozts85f0/arch/riscv/include/asm/barrier.h:14,
                 from /build/tmpozts85f0/include/asm-generic/bitops/generic-non-atomic.h:7,
                 from /build/tmpozts85f0/include/linux/bitops.h:28,
                 from /build/tmpozts85f0/include/linux/thread_info.h:27,
                 from /build/tmpozts85f0/include/asm-generic/preempt.h:5,
                 from ./arch/riscv/include/generated/asm/preempt.h:1,
                 from /build/tmpozts85f0/include/linux/preempt.h:79,
                 from /build/tmpozts85f0/include/linux/spinlock.h:56,
                 from /build/tmpozts85f0/include/linux/mmzone.h:8,
                 from /build/tmpozts85f0/include/linux/gfp.h:7,
                 from /build/tmpozts85f0/include/linux/mm.h:7,
                 from /build/tmpozts85f0/arch/riscv/kernel/asm-offsets.c:9:
/build/tmpozts85f0/arch/riscv/include/asm/pgtable-64.h: In function 'riscv_page_mtmask':
/build/tmpozts85f0/arch/riscv/include/asm/errata_list.h:75:5: error: expected string literal before 'ALTERNATIVE_3'
   75 | asm(ALTERNATIVE_3("li %0, 0\t\nnop",                                    \
      |     ^~~~~~~~~~~~~
/build/tmpozts85f0/arch/riscv/include/asm/pgtable-64.h:154:9: note: in expansion of macro 'ALT_SVPBMT'
  154 |         ALT_SVPBMT(val, _PAGE_MTMASK);
      |         ^~~~~~~~~~
/build/tmpozts85f0/arch/riscv/include/asm/pgtable-64.h: In function 'riscv_page_nocache':
/build/tmpozts85f0/arch/riscv/include/asm/errata_list.h:75:5: error: expected string literal before 'ALTERNATIVE_3'
   75 | asm(ALTERNATIVE_3("li %0, 0\t\nnop",                                    \
      |     ^~~~~~~~~~~~~
/build/tmpozts85f0/arch/riscv/include/asm/pgtable-64.h:162:9: note: in expansion of macro 'ALT_SVPBMT'
  162 |         ALT_SVPBMT(val, _PAGE_NOCACHE);
      |         ^~~~~~~~~~
/build/tmpozts85f0/arch/riscv/include/asm/pgtable-64.h: In function 'riscv_page_io':
/build/tmpozts85f0/arch/riscv/include/asm/errata_list.h:75:5: error: expected string literal before 'ALTERNATIVE_3'
   75 | asm(ALTERNATIVE_3("li %0, 0\t\nnop",                                    \
      |     ^~~~~~~~~~~~~
/build/tmpozts85f0/arch/riscv/include/asm/pgtable-64.h:170:9: note: in expansion of macro 'ALT_SVPBMT'
  170 |         ALT_SVPBMT(val, _PAGE_IO);
      |         ^~~~~~~~~~
make[3]: *** [/build/tmpozts85f0/scripts/Makefile.build:184: arch/riscv/kernel/asm-offsets.s] Error 1
make[3]: Target 'prepare' not remade because of errors.
make[2]: *** [/build/tmpozts85f0/Makefile:1333: prepare0] Error 2
make[2]: Target '__all' not remade because of errors.
make[1]: *** [/build/tmpozts85f0/Makefile:248: __sub-make] Error 2
make[1]: Target '__all' not remade because of errors.
make: *** [Makefile:248: __sub-make] Error 2
make: Target '__all' not remade because of errors.
make --silent --keep-going --jobs=48 O=/build/tmp.Kz9P4XAuHf/build INSTALL_DTBS_PATH=/build/tmp.Kz9P4XAuHf/build/dtbsinstall/dtbs ARCH=riscv CROSS_COMPILE=riscv64-linux- 'CC=ccache riscv64-linux-gcc' 'HOSTCC=ccache gcc' dtbs
rm -rf /build/tmp.Kz9P4XAuHf/build/dtbsinstall
mkdir -p /build/tmp.Kz9P4XAuHf/build/dtbsinstall/dtbs
make --silent --keep-going --jobs=48 O=/build/tmp.Kz9P4XAuHf/build INSTALL_DTBS_PATH=/build/tmp.Kz9P4XAuHf/build/dtbsinstall/dtbs ARCH=riscv CROSS_COMPILE=riscv64-linux- 'CC=ccache riscv64-linux-gcc' 'HOSTCC=ccache gcc' dtbs_install
tar --sort=name --owner=tuxmake:1000 --group=tuxmake:1000 --mtime=@1773641498 --clamp-mtime -caf /build/tmp.Kz9P4XAuHf/build/dtbs.tar -C /build/tmp.Kz9P4XAuHf/build/dtbsinstall dtbs
rm -rf /build/tmp.Kz9P4XAuHf/build/install_hdr
make --silent --keep-going --jobs=48 O=/build/tmp.Kz9P4XAuHf/build INSTALL_HDR_PATH=/build/tmp.Kz9P4XAuHf/build/install_hdr/ ARCH=riscv CROSS_COMPILE=riscv64-linux- 'CC=ccache riscv64-linux-gcc' 'HOSTCC=ccache gcc' headers_install
tar --sort=name --owner=tuxmake:1000 --group=tuxmake:1000 --mtime=@1773641498 --clamp-mtime -caf /build/tmp.Kz9P4XAuHf/build/headers.tar -C /build/tmp.Kz9P4XAuHf/build/install_hdr .
warnings/errors:
/build/tmpozts85f0/arch/riscv/include/asm/errata_list.h:75:5: error: expected string literal before 'ALTERNATIVE_3'
/build/tmpozts85f0/arch/riscv/include/asm/errata_list.h:75:5: error: expected string literal before 'ALTERNATIVE_3'
/build/tmpozts85f0/arch/riscv/include/asm/errata_list.h:75:5: error: expected string literal before 'ALTERNATIVE_3'


@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,v2,3/3] riscv: errata: sifive: Add an "errata" to simulate Svpbmt on cores without"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.53 seconds
Result: WARNING
Output:

CHECK: Consider using #include <linux/cacheflush.h> instead of <asm/cacheflush.h>
#108: FILE: arch/riscv/errata/sifive/errata.c:17:
+#include <asm/cacheflush.h>

CHECK: Please use a blank line after function/struct/union/enum declarations
#273: FILE: arch/riscv/include/asm/pgtable-64.h:86:
+}
+#define _PAGE_PFN_MASK  riscv_pfn_mask()

total: 0 errors, 0 warnings, 2 checks, 179 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 171d9f373182 ("riscv: errata: sifive: Add an "errata" to simulate Svpbmt on cores without") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 2 checks, 179 lines checked
CHECK: Consider using #include <linux/cacheflush.h> instead of <asm/cacheflush.h>
CHECK: Please use a blank line after function/struct/union/enum declarations


@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,v2,3/3] riscv: errata: sifive: Add an "errata" to simulate Svpbmt on cores without"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 82.54 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,v2,3/3] riscv: errata: sifive: Add an "errata" to simulate Svpbmt on cores without"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,v2,3/3] riscv: errata: sifive: Add an "errata" to simulate Svpbmt on cores without"
kdoc
Desc: Detects for kdoc errors
Duration: 0.85 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,v2,3/3] riscv: errata: sifive: Add an "errata" to simulate Svpbmt on cores without"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,v2,3/3] riscv: errata: sifive: Add an "errata" to simulate Svpbmt on cores without"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.21 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[RFC,v2,3/3] riscv: errata: sifive: Add an "errata" to simulate Svpbmt on cores without"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.28 seconds
Result: PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants