Repository navigation
hfsplus: fix xattr entrylength OOB read and NULL hidden_dir on R/W remount - #2626
Closed
vfsci-bot[bot] wants to merge 1 commit into
Closed
vfsci-bot[bot] wants to merge 1 commit into
vfsci-bot[bot] wants to merge 1 commit into
Conversation
…mount Fix three issues in fs/hfsplus/: 1. In __hfsplus_getxattr() (fs/hfsplus/xattr.c), verify that record_length and attr_size fit within fd.entrylength before copying from the catalog or attributes btree entry so a malformed attribute length cannot trigger a slab-out-of-bounds read or leak uninitialized slab memory. 2. In hfsplus_delete_all_attrs() (fs/hfsplus/attributes.c), return early if HFSPLUS_SB(sb)->attr_tree is NULL. 3. In hfsplus_reconfigure() and hfsplus_unlink() (fs/hfsplus/super.c, fs/hfsplus/dir.c), allocate hidden_dir when remounting from read-only to read-write and guard against NULL hidden_dir when unlinking open files. Fixes: 127e5f5 ("hfsplus: rework functionality of getting, setting and deleting of extended attributes") Assisted-by: LLM Signed-off-by: Hui Peng <benquike@gmail.com>
Author
|
This PR is older than 14 days. Closing automatically. If the series is still relevant, a new version will create a new PR. Automated by ml2pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Series: https://patchwork.kernel.org/project/linux-fsdevel/list/?series=1169472
Submitter: Hui Peng
Version: 1
Patches: 1/1
Message-ID:
<20260919222603.3794265-1-benquike@gmail.com>Base: vfs.base.ci
Lore: https://lore.kernel.org/linux-fsdevel/20260919222603.3794265-1-benquike@gmail.com
Automated by ml2pr