Repository navigation
fat: avoid freeing clusters on failed directory validation or read-only mounts - #2614
Closed
vfsci-bot[bot] wants to merge 1 commit into
Closed
vfsci-bot[bot] wants to merge 1 commit into
vfsci-bot[bot] wants to merge 1 commit into
Conversation
…ly mounts In fat_fill_inode(), set_nlink(inode, fat_subdirs(inode)) is called before fat_validate_dir(inode). If a directory has zero valid subdirectories (so fat_subdirs(inode) returns 0) and fat_validate_dir() subsequently returns -EIO (due to a missing or malformed '.'/'..' entry), fat_build_inode() calls iput(inode) with inode->i_nlink == 0 and inode->i_start still populated. fat_evict_inode() then checks !inode->i_nlink without checking is_bad_inode(inode) or sb_rdonly(inode->i_sb) and calls fat_truncate_blocks(inode, 0), freeing the cluster chain on disk even on a read-only (MS_RDONLY) mount. Validate the directory before setting i_nlink in fat_fill_inode(), mark the inode bad on error in fat_build_inode(), and guard cluster truncation and metadata writeback in fat_evict_inode() with !is_bad_inode(inode) && !sb_rdonly(inode->i_sb). Fixes: a3082d5 ("fat: add simple validation for directory inode") Assisted-by: LLM Signed-off-by: Hui Peng <benquike@gmail.com>
Author
|
This PR is older than 14 days. Closing automatically. If the series is still relevant, a new version will create a new PR. Automated by ml2pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Series: https://patchwork.kernel.org/project/linux-fsdevel/list/?series=1169397
Submitter: Hui Peng
Version: 1
Patches: 1/1
Message-ID:
<20260919204810.2813594-1-benquike@gmail.com>Base: vfs.base.ci
Lore: https://lore.kernel.org/linux-fsdevel/20260919204810.2813594-1-benquike@gmail.com
Automated by ml2pr