Tidy ups - #413
Merged
Merged
Tidy ups#413
Conversation
An earlier PR updated the generated files manually. The script itself fell behind.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain.
Pull request overview
Tidies generated test fakes, workflow generation, and Go module metadata.
Changes:
- Preserve variadic AWS options in generated fakes.
- Restrict generated workflow pushes to
main. - Refresh Go dependencies and checksums.
File summaries
| File | Description |
|---|---|
internal/backendstore/backendstorefakes/fake_stsclient.go |
Copies recorded STS options. |
internal/backendstore/backendstorefakes/fake_s3client.go |
Copies recorded S3 options. |
hack/generate-tests.sh |
Updates workflow push triggers. |
go.sum |
Refreshes dependency checksums. |
go.mod |
Updates Go and dependency declarations. |
Review details
Files not reviewed (2)
- internal/backendstore/backendstorefakes/fake_s3client.go: Generated file
- internal/backendstore/backendstorefakes/fake_stsclient.go: Generated file
- Files reviewed: 3/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fix outdated
generate-testsscript, updatebuildsubmodule, and ranmake generate-pkgI have:
make ready-for-reviewto ensure this PR is ready for review.make ceph-chainsawto validate these changes against Ceph. This step is not always necessary. However, for changes related to S3 calls it is sensible to validate against an actual Ceph cluster. Localstack is used in our CI Chainsaw suite for convenience and there can be disparity in S3 behaviours between it and Ceph. Seedocs/TESTING.mdfor information on how to run tests against a Ceph cluster.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
CI and running locally