Repository navigation
TPT-4654: Support NodeBalancer types and backend connectivity - #890
Open
zliang-akamai wants to merge 3 commits into
Open
zliang-akamai wants to merge 3 commits into
zliang-akamai wants to merge 3 commits into
Conversation
zliang-akamai
requested review from
jcamelon and
mawilk90
and
a balanced review from Copilot
and removed request for
a team
October 14, 2026 20:18
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Returned connectivity metadata can be stale, and unconditional gated-feature tests break integration runs on accounts without access.
3 open findings
What changed in this PR
Adds NodeBalancer type and backend connectivity support to the linode.cloud collection.
Changes:
- Accepts creation-only type, connectivity, and VPC options without including them in updates.
- Documents backend addressing and returned metadata.
- Adds unit coverage and extends populated integration tests for Premium/IPv6 behavior.
| File | Description |
|---|---|
| tests/unit/modules/test_nodebalancer.py | Tests creation forwarding and update exclusions. |
| tests/integration/targets/nodebalancer_populated/tasks/main.yaml | Exercises Premium/IPv6 behavior and metadata consistency. |
| plugins/modules/nodebalancer.py | Adds creation-only options and addressing documentation. |
| plugins/modules/nodebalancer_node.py | Documents connectivity-specific backend addresses. |
| plugins/module_utils/doc_fragments/nodebalancer.py | Adds connectivity examples and return metadata. |
| plugins/module_utils/doc_fragments/nodebalancer_node.py | Clarifies the example’s address comment. |
| plugins/module_utils/doc_fragments/nodebalancer_list.py | Adds returned metadata examples. |
| docs/modules/nodebalancer.md | Updates generated options, examples, and returns. |
| docs/modules/nodebalancer_node.md | Updates generated addressing guidance. |
| docs/modules/nodebalancer_list.md | Documents additional list metadata. |
| docs/modules/nodebalancer_info.md | Documents additional info metadata. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
zliang-akamai
requested review from
a team and
lgarber-akamai
and removed request for
a team and
jcamelon
October 14, 2026 20:26
zliang-akamai
force-pushed
the
zhiwei/TPT-4654/nodebalancer-backend-connectivity
branch
2 times, most recently
from
October 15, 2026 02:13
1ad03e7 to
64880f6
Compare
zliang-akamai
force-pushed
the
zhiwei/TPT-4654/nodebalancer-backend-connectivity
branch
from
October 15, 2026 02:17
64880f6 to
8ab6350
Compare
Comment on lines
+307
to
+308
| "This cannot be changed after creation. This option requires " | ||
| "v4beta API access and may not be available to all accounts.", |
| @@ -49,8 +49,10 @@ | |||
| type=FieldType.string, | |||
Contributor
There was a problem hiding this comment.
Do we need to support a node-level subnet_id field both here and in the nodebalancer module? Not entirely sure myself
https://techdocs.akamai.com/linode-api/reference/post-node-balancer-node
Member
Author
There was a problem hiding this comment.
Yes, it will be a separate PR for an easier review
lgarber-akamai
approved these changes
Oct 19, 2026
lgarber-akamai
left a comment
lgarber-akamai
left a comment
Contributor
There was a problem hiding this comment.
LGTM and tests are passing!
mawilk90
requested review from
psnoch-akamai
and removed request for
mawilk90
October 20, 2026 10:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Add Ansible support for the NodeBalancer API changes covered by linode/linode_api4-python#735 and linode/linode_api4-python#745.
type,backend_connectivity, andvpcsoptions without sending them in update requests.type,backend_connectivity, and read-onlybackend_ipv6_prefixmetadata.us-miathat validates returned metadata.Per-node subnet support is intentionally left for a follow-up. The unavailable
/backend_aclendpoint is not added.✔️ How to Test
Run
make test-int TEST_SUITE=nodebalancer_premium.