Skip to content

perf(ai): avoid full root execution hydration for history usage #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ice-black-tea merged 1 commit into from
Nov 15, 2026
Merged

perf(ai): avoid full root execution hydration for history usage #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion linktools-ai/src/linktools/ai/history/_history.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,7 +819,7 @@ async def usage(
builtin = type(executions) is ExecutionRepositoryImpl
read_execution = executions.get_header if builtin else executions.get
read_children = executions.list_child_views if builtin else executions.list_children
await self._authorized_record(execution_id, principal)
await self._authorized_record(execution_id, principal, metadata_only=True)
explicit_ids = (
None if cutoffs is None else {value.execution_id for value in cutoffs}
)
Expand Down
16 changes: 8 additions & 8 deletions tests/ai/test_usage_tree_control_reads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
# -*- coding: utf-8 -*-
"""Usage traversal preserves per-node authorization without loading payloads."""

from pathlib import Path

import pytest

from linktools.ai.core import Principal, TenantAuthorizationPolicy
Expand All @@ -15,12 +17,15 @@


@pytest.mark.asyncio
@pytest.mark.parametrize("backend", ("memory", "sqlite"))
@pytest.mark.parametrize("graph", (False, True))
@pytest.mark.parametrize("outcome", ("success", "denied", "missing"))
async def test_usage_tree_reads_only_membership_after_initial_authorization(
monkeypatch: pytest.MonkeyPatch, graph: bool, outcome: str,
monkeypatch: pytest.MonkeyPatch, tmp_path: Path, backend: str, graph: bool, outcome: str,
) -> None:
async with Persistence.open("execution-query", tenant_id="tenant", storage=PersistenceStorage.in_memory()) as state:
storage = (PersistenceStorage.in_memory() if backend == "memory"
else PersistenceStorage.sqlite(tmp_path / "usage.db"))
async with Persistence.open("execution-query", tenant_id="tenant", storage=storage) as state:
repository = state.execution.executions
for record in (_record("root", agent_id="agent"),
_record("child", agent_id="agent", parent_execution_id="root")):
Expand All @@ -29,15 +34,11 @@ async def test_usage_tree_reads_only_membership_after_initial_authorization(
history_type = _GraphUsageHistory if graph else History
history = history_type(service, tenant_id="tenant", executions=repository,
authorization=TenantAuthorizationPolicy("tenant"))
original_get = repository.get
original_header = repository.get_header
original_usage = service.usage
full_reads = []

async def read_full(execution_id, *, tenant_id):
full_reads.append(execution_id)
assert not graph and full_reads == ["root"]
return await original_get(execution_id, tenant_id=tenant_id)
raise AssertionError("usage authorization loaded execution bodies")

async def read_header(execution_id, *, tenant_id):
if outcome == "missing" and execution_id == "child":
Expand Down Expand Up @@ -68,4 +69,3 @@ async def reject_full_children(*args, **kwargs):
assert raised.value.code is (ErrorCode.AUTHORIZATION_DENIED if outcome == "denied"
else ErrorCode.STORAGE_INTEGRITY_ERROR)
assert service.calls == ["root"]
assert full_reads == ([] if graph else ["root"])
Loading