Repository navigation
Reject unsupported Session scheduling enum values - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Session accepted unknown FIFO capacity units, send policies and deadline policies. Unknown send enum values could reach the queue and backend instead of being rejected as invalid configuration.
Change
Validate
SessionOptions::fifo_unitbefore configuration assignment and validateSendOptions::policyandSendOptions::deadline_policybefore Job allocation and admission. Unsupported values throwValidationError.No public signatures, enum values or defaults change. Supported configurations retain their existing behavior. The shared submission path covers Session, DeviceSession and registered operations; conditional latest replacement retains its policy requirement.
Regression tests check negative and out-of-range positive values, configuration preservation, empty-queue rejection, pending queue counters, preservation of an existing latest receipt, and the frames actually sent after the writer gate is released. They also exercise all supported send/deadline combinations and installed-package consumers. Both documentation editions describe rejection behavior.
Validation
Local Linux ARM64 / GCC 13 Debug:
All 36 CI checks passed on commit 5b334c1, including the full quality report, style checks, sanitizers, GCC/libc++ builds, Windows native tests, packages and installed consumers. No unresolved review threads were present at the final check. Tests use fake transports and do not establish hardware compatibility.