Repository navigation
Honor explicit pending-age scopes in device sessions - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DeviceSession rewrote
PendingAgeScope::kSessionto endpoint scope, so an explicit whole-Session age check could ignore older work belonging to another device.Change
Add
PendingAgeScope::kDefaultand resolve it at the submission boundary: whole Session for Session entry points, local endpoint for DeviceSession entry points. Explicit Session, endpoint and admission-domain selections remain explicit through ordinary submissions, registered operations and conditional latest replacement.Existing enum values, field types and function signatures are unchanged. Default admission behavior is retained for both entry points. The default field enumerator changes from
kSessiontokDefault; code explicitly settingkSessionon a device now checks the whole Session. No scheduling queue or connection ownership changes are included.Update both documentation editions and add regression and installed-consumer coverage.
Validation
Local Linux ARM64 / GCC 13 Debug:
All 36 CI checks passed on commit 7ceb2b5, including the full quality report, style checks, GCC/libc++ builds, sanitizers, Windows native tests, packages and installed consumers. No unresolved review threads were present at the final check. These tests use fake transports; no hardware behavior change or hardware acceptance result is claimed.