Skip to content

Honor explicit pending-age scopes in device sessions - #25

Merged
soulteary merged 1 commit into
mainfrom
fix/pending-age-scope
Nov 6, 2026
Merged

soulteary merged 1 commit into
mainfrom
fix/pending-age-scope

Conversation

@soulteary

@soulteary soulteary commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Problem

DeviceSession rewrote PendingAgeScope::kSession to endpoint scope, so an explicit whole-Session age check could ignore older work belonging to another device.

Change

Add PendingAgeScope::kDefault and resolve it at the submission boundary: whole Session for Session entry points, local endpoint for DeviceSession entry points. Explicit Session, endpoint and admission-domain selections remain explicit through ordinary submissions, registered operations and conditional latest replacement.

Existing enum values, field types and function signatures are unchanged. Default admission behavior is retained for both entry points. The default field enumerator changes from kSession to kDefault; code explicitly setting kSession on a device now checks the whole Session. No scheduling queue or connection ownership changes are included.

Update both documentation editions and add regression and installed-consumer coverage.

Validation

Local Linux ARM64 / GCC 13 Debug:

  • 335/335 CTest cases passed.
  • Production line coverage: 5453/5503 (99.09140%, before rounding).
  • 4/4 installed-consumer tests passed.
  • Strict Clang 18 project/test checks and the broader quality-report analyzer checks passed for the changed implementation and test translation units.
  • Temporarily restoring the device's Session-to-endpoint rewrite causes the new explicit-Session regression to fail at the expected assertion. Restoring the fix passes the full suite.

All 36 CI checks passed on commit 7ceb2b5, including the full quality report, style checks, GCC/libc++ builds, sanitizers, Windows native tests, packages and installed consumers. No unresolved review threads were present at the final check. These tests use fake transports; no hardware behavior change or hardware acceptance result is claimed.

@soulteary
soulteary marked this pull request as ready for review November 6, 2026 08:13
@soulteary
soulteary merged commit 304847f into main Nov 6, 2026
36 checks passed
@soulteary
soulteary deleted the fix/pending-age-scope branch November 6, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant