feat: add Docker network isolation options - #155
Merged
Conversation
Adding .gitkeep for PR creation (default mode). This file will be removed when the task is complete. Issue: #154
Apply network settings during docker run so detached commands cannot race network attachment. Clean up containers left in the created state when launch fails. Refs #154
konard
marked this pull request as ready for review
August 9, 2026 03:18
Member
Author
Working session summaryImplemented and finalized PR #155.
This summary was automatically extracted from the AI working session output. |
Member
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
📊 Context and tokens usage:
Total: (332.1K + 11.8M cached) input tokens, 45.4K output tokens, $17.205875 cost 🤖 Models used:
📎 Log file uploaded as Gist (4662KB)Now working session is ended, feel free to review and add any feedback on the solution draft. |
Member
Author
🎉 Auto-mergedThis pull request has been automatically merged by hive-mind.
Auto-merged by hive-mind with --auto-merge flag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #154.
Summary
--network <name>/--network=<name>parsing and repeatable--network-aliassupport in JavaScript and Rust.docker runcommands, so child commands cannot race network attachment.createdafter launch errors such as a missing network, while preserving containers that existed before launch.Reproduction
Before this change:
docker network create --internal hive-formal-ai $ --isolated docker --image alpine:3.23 --network hive-formal-ai -- echo okfailed with
Error: Unknown wrapper option: --network.Verification
The new real-daemon tests create an internal network and an aliased sidecar. A detached task on that network resolves the alias and exits 0, while an unconnected control cannot resolve it. They also verify that missing-network failures leave no orphan and that a name conflict never deletes a pre-existing container.
cd js && bun run test— 712 passedcargo test --manifest-path rust/Cargo.toml --all-features --verbosecd js && bun run lint && bun run format:check && bun run check:file-sizecargo fmt --manifest-path rust/Cargo.toml --all -- --checkcargo clippy --manifest-path rust/Cargo.toml --all-targets --all-featuresnode scripts/check-test-parity.mjsnode scripts/check-doc-examples.mjs --implementation jsnode scripts/check-doc-examples.mjs --implementation rustcd js && bunx changeset status --since=origin/mainScreenshots are not applicable because this changes CLI and Docker runtime behavior.