fix(docs): gate GitHub Pages deployment - #30
Merged
Conversation
Adding .gitkeep for PR creation (default mode). This file will be removed when the task is complete. Issue: #26
konard
marked this pull request as ready for review
July 3, 2026 16:12
Member
Author
Working session summaryImplemented and pushed the fix to PR #30: #30 Changed:
Verified locally:
PR #30 is marked ready for review. Latest GitHub runs for commit This summary was automatically extracted from the AI working session output. |
Member
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
📊 Context and tokens usage:
Total: (101.9K + 1.5M cached) input tokens, 15.7K output tokens, $3.202647 cost 🤖 Models used:
📎 Log file uploaded as Gist (1409KB)Now working session is ended, feel free to review and add any feedback on the solution draft. |
Member
Author
🎉 Auto-mergedThis pull request has been automatically merged by hive-mind.
Auto-merged by hive-mind with --auto-merge flag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26
Summary
Docsworkflow building Sphinx docs on pushes and pull requests.configure-pages,upload-pages-artifact, anddeploy-pagesonvars.DEPLOY_GITHUB_PAGES == 'true'.pushtomainwhen Pages deployment has not been opted in.DEPLOY_GITHUB_PAGES=truerepository variable.Reproduction
Before the workflow fix,
python -m pytest tests/test_workflows.py::test_docs_workflow_deploys_pages_only_when_opted_in -qfailed because the docs workflow had no skip step and deployed Pages on everypushtomain.Verification
python -m pytest tests/test_workflows.py::test_docs_workflow_deploys_pages_only_when_opted_in -qpython -m pytest tests/test_workflows.py -qpython -m pytestruff check .ruff format --check .mypy src/(passes with existing local warnings about Python 3.9 config support and deprecated--strict-concatenateunder Python 3.14)python scripts/check_file_size.pygit diff --check.github/workflows/docs.yml