Add automation-friendly browser launch defaults - #74
Merged
Conversation
Adding .gitkeep for PR creation (default mode). This file will be removed when the task is complete. Issue: #70
This reverts commit 7b1f61d.
konard
marked this pull request as ready for review
August 2, 2026 06:28
Member
Author
Working session summaryImplemented and finalized PR #74.
💰 Cost estimation:
📊 Context and tokens usage:
Total: (319.7K + 11.0M cached) input tokens, 53.8K output tokens, $16.635621 cost This summary was automatically extracted from the AI working session output. |
Member
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
📊 Context and tokens usage:
Total: (319.7K + 11.0M cached) input tokens, 53.8K output tokens, $16.635621 cost 🤖 Models used:
📎 Log file uploaded as Gist (4402KB)Now working session is ended, feel free to review and add any feedback on the solution draft. |
Member
Author
🎉 Auto-mergedThis pull request has been automatically merged by hive-mind.
Auto-merged by hive-mind with --auto-merge flag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--password-store=basic, first-run suppression, and the existing crash/infobar protections--headless=newwhen requestedextraArgs/extra_args/ Rust extra-argument builders and per-default opt-outs without breaking the existingargsAPIsRoot cause and reproduction
The shared launch argument lists did not include
--password-store=basic, so a fresh Chrome-family profile could invoke the operating-system credential backend. The installed-browser launch helpers also hard-coded only the two first-run flags, and none of the language APIs resolved additive arguments together with per-default opt-outs.Before this change, inspecting the default arguments produced by
launchBrowser/launch_browserorbuildRealBrowserArgs/build_real_browser_argsshowed that--password-store=basicwas absent. The new unit regressions assert that it is present by default, custom arguments retain append order, individual defaults (including the password-store flag itself) can be omitted, and managed CDP/profile arguments remain protected.connectBrowser/connect_browserattaches to an already-running process and therefore cannot alter its command line. The documentation now makes that boundary explicit and points callers to the real-browser launch helper or equivalent external flags.Verification
origin/mainis includedFixes #70