Repository navigation
chore(deps-dev): bump the development-dependencies group across 1 directory with 7 updates #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tianxiaochannel-oss88
merged 10 commits into
main
from
dependabot/npm_and_yarn/development-dependencies-214ac9047f
Nov 7, 2026
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7f2fc75
chore(deps-dev): bump the development-dependencies group across 1 dir…
dependabot[bot] 7239230
fix(desktop): align Builder pins and reviewed Electron runtime
tianxiaochannel-oss88 0c378c1
Merge branch 'main' into dependabot/npm_and_yarn/development-dependen…
tianxiaochannel-oss88 fc44b9a
Merge branch 'main' into dependabot/npm_and_yarn/development-dependen…
tianxiaochannel-oss88 ceb0513
Merge branch 'main' into dependabot/npm_and_yarn/development-dependen…
tianxiaochannel-oss88 91783b5
chore(deps): sync desktop dependency update with main
tianxiaochannel-oss88 c2cb358
fix(deps): remove lockfile merge markers
tianxiaochannel-oss88 ff1d7be
test(daemon): record owned execution phase diagnostics
tianxiaochannel-oss88 498c6db
fix(daemon): type diagnostic probe environment
tianxiaochannel-oss88 8d4c072
Merge origin/main into dependabot development dependencies
tianxiaochannel-oss88 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
apps/desktop/scripts/cua-driver-signing/electron-builder-win-sign.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
apps/desktop/scripts/distribution/vendor-notices/nsis-source.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,12 @@ | ||
| { | ||
| "schemaVersion": 1, | ||
| "component": "NSIS embedded zlib runtime and compiler headers", | ||
| "appBuilderLibVersion": "26.15.3", | ||
| "appBuilderLibVersion": "26.18.0", | ||
| "toolsetModuleSha256": "a6e3009ca9680aec48646793289224a8df26cfb9c8dafba1e3b08323f09a331b", | ||
| "releaseName": "nsis-3.0.4.1", | ||
| "archive": "https://github.com/electron-userland/electron-builder-binaries/releases/download/nsis-3.0.4.1/nsis-3.0.4.1.7z", | ||
| "archiveSha256": "9877df902530f96357d13a7a31ae2b9df67f48b11ffc9a1700a7c961574ec5fa", | ||
| "licensePath": "COPYING", | ||
| "licenseSha256": "3c8de989f6504d52f5f8dfafedb6668cd47201f5d01f1319570727c091425dd6", | ||
| "scope": "Original COPYING from the exact compiler archive selected by app-builder-lib 26.15.3. The private stock-template overlay retains stock upgrade/rollback and 7z extraction, replaces WinShell calls with MIT LingShell System/COM macros, and removes SpiderBanner display calls. StdUtils/nsis7z original paired source archives are supplied separately." | ||
| "scope": "Original COPYING from the exact compiler archive selected by app-builder-lib 26.18.0. The private stock-template overlay retains stock upgrade/rollback and 7z extraction, replaces WinShell calls with MIT LingShell System/COM macros, and removes SpiderBanner display calls. StdUtils/nsis7z original paired source archives are supplied separately." | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| # macOS development packaging dependency review, 2026-11-03 | ||
|
|
||
| This review covers PR #633 at | ||
| `7f2fc754102f2c49e5e238ead027468f34da0023` plus its Builder compatibility | ||
| corrections, against main `b5713e56ccea5ab75c5c8450d4c8f275c20b1c70`. | ||
| It updates only the existing Darwin arm64, `unsigned_dev`, ad-hoc, | ||
| `provider=false` source prerequisite. It does not accept a final App, ZIP, DMG, | ||
| public signature, notarization, GUI behavior or release. | ||
|
|
||
| ## Compatibility review | ||
|
|
||
| The seven proposed dependency updates are retained: Node types 26.6.6, | ||
| osx-sign 2.7.2, Electron 45.2.1, Electron Builder 26.18.0, Vite 8.3.5, | ||
| expo-doctor 1.21.5 and Babel parser 8.0.10. Builder is now pinned exactly to | ||
| 26.18.0. Its installer, extractor and signing-trace consumers share the existing | ||
| version constant, while both Builder package-version checks remain strict. | ||
|
|
||
| Independent Codex context `01a1a05f-591b-77a1-86de-2bf4f7e4300e` found no | ||
| blocking dependency-graph or Builder-integration defect in these exact bytes. | ||
| The structured lock audit covered 20 importers, 1,391 packages, 1,395 snapshots | ||
| and 3,123 transitive dependency edges, with no dangling reference. All 22 | ||
| overrides and nine security patches, including their hashes, remain intact. | ||
|
|
||
| The four pinned NSIS templates and the Windows toolset module are byte-identical | ||
| between the two Builder versions. Their existing hash guards are unchanged. | ||
| The NSIS source receipt changes its Builder version reference only, retaining | ||
| the compiler archive and license hashes. The other NSIS template change adds | ||
| `-NoProfile -NonInteractive` to four PowerShell calls without changing the macro | ||
| interface or fallback. Both signing callback contracts remain compatible. | ||
| Squirrel remains outside this review: its existing 26.15.3 package is not used | ||
| by the current `dir`/NSIS path, and its peer-version mismatch is not accepted | ||
| as a tested Squirrel configuration. | ||
|
|
||
| ## Independent source and runtime decision | ||
|
|
||
| Separate Codex context `01a1a065-bf2b-74a0-b649-ec0012776b23` independently | ||
| reviewed the exact record proposal and returned `SCOPED SOURCE-REVIEW PASS` | ||
| before either persistent record was changed. These are independent contexts | ||
| on the same model host, not human or cross-model approval. | ||
|
|
||
| The source audit retains 43 roots and 1,706 unique fixed inputs. It parsed | ||
| 1,630 authored files and reached 1,639, with no missing input, unresolved authored | ||
| import or parse error. The new version-constant imports target an already fixed | ||
| module, with no build-time approval discovery or new top-level write effect. | ||
| All 15 Office and 19 sandbox native input digests remain unchanged. | ||
|
|
||
| The actual Electron runtime is 45.2.1, with embedded Node 24.22.1 and libuv | ||
| 1.52.1, on Darwin arm64. Both records change only their Electron and Node | ||
| runtime fields. Compiler, SDK, headers, deployment target, OS rows, trust, | ||
| signing, approval fields and false/unbound safety axes are unchanged. | ||
|
|
||
| The sandbox record was adopted first. The Office record then adopted exactly | ||
| the following ten existing packaging digest replacements. No key was added | ||
| or removed; the other 1,697 values are unchanged. | ||
|
|
||
| | Existing packaging input | Approved SHA-256 | | ||
| | --- | --- | | ||
| | `apps/desktop/package.json` | `d8d064c0ea099c78d90b83462d90e590a9d5b4189eb997d0cee8f018cdd382f8` | | ||
| | `packages/core/src/provider-model-catalog.generated.ts` | `c02eaf49e0f4e79f94cb18734d2613a3e9c88e4ca1250d9b353dc0574f7c41e4` | | ||
| | `pnpm-lock.yaml` | `bea9a0f9bd2771063b97e1fd47f20aa43325670213909bcad06033e12fa2a1ad` | | ||
| | `packages/daemon/package.json` | `1f44188e8a668392c8573c011e1aa80e9d589cba7036d6a97315f5445c40898b` | | ||
| | `apps/desktop/scripts/distribution/installer-builder.mjs` | `4f67d19706b4f000a1ab90590932190fb6889803578d9bf0d9bfc38a7fab817d` | | ||
| | `apps/desktop/scripts/cua-driver-signing/electron-builder-mac-sign.mjs` | `7000392b8ca2f4151442773d8150fddcd1c758ab6ad5516a5a7dfdc098ea1ead` | | ||
| | `apps/desktop/scripts/cua-driver-signing/final-artifact-extractor.mjs` | `97e45821742403beaf936ebb5393633845b5be111e346266ec1f186af02efdc4` | | ||
| | `apps/desktop/scripts/cua-driver-signing/hooks.mjs` | `61a37e71e5f6df0b6113cc558eff86210dcf80eeb0d825d3060198d8eff7f76e` | | ||
| | `apps/desktop/scripts/cua-driver-signing/signing-trace.mjs` | `8d8403ecb6d2f3a8c9f7405d51535a61e3e048e4bd19d33cfeaa747ea380eb0e` | | ||
| | `native/sandbox/reviewed-codesign-source-v1.json` | `5e4e8cc68a68f4901244aa773ca04787805021f61c714ab64b52bf960c328572` | | ||
|
|
||
| The adopted Office record SHA-256 is | ||
| `c974cf2253ac6d754c9f2cb7141032133d58d7bb0c5d1b17a5827c72b9c8806c`. | ||
| The fixed-order packaging aggregate is | ||
| `069e86b5b33420eacba6a4bf8280433a8245f52fe394cbf44d7e502e514f0c3b`. | ||
| The unchanged Office and sandbox native aggregates are respectively | ||
| `9c5f6a1a05fe63ab96de941432ec13166af8974ec52730934d5ac348c41a854e` | ||
| and `6770a6864706c68c41ed4998c826daeff7e33baf7d59d9d9cfca8a9b63da1dbd`. | ||
| Aggregates encode fixed-order `[path, sha256]` pairs as JSON plus a newline. | ||
|
|
||
| ## Verification and limits | ||
|
|
||
| - Before adoption, the actual committed-form Office record test failed on the | ||
| stale Desktop manifest digest. After adoption, all 1,706 packaging inputs | ||
| and all native inputs match, and the exact record/field comparison permits | ||
| only the independently reviewed changes above. | ||
| - The actual strict Office reader, default local Office reader and codesign | ||
| reader accepted the final records and fresh native build evidence using the | ||
| already approved local Xcode/SDK/header profile, without observer mocks or | ||
| a new toolchain allowance. | ||
| - Office publication, codesign publication, authored-input and toolchain | ||
| contract tests passed 227/227 with no skips. Their disposable synthetic | ||
| compiler/signature cases do not establish final artifact acceptance. | ||
| - Fresh Office compilation passed. Primitive/publication/readback suites | ||
| passed 48/48 under standalone Node and 48/48 under actual Electron 45.2.1, | ||
| with equal before/after source fingerprints and no fixture residue. The | ||
| first Electron run passed 47/48 because its confined actor used a symlinked | ||
| Node path; that failed run was retained. Selecting the canonical standalone | ||
| actor path through the existing test-only setting resolved it without | ||
| changing source, tests or policy. | ||
| - The fresh sandbox build recorded 26 Rust passes and two existing ignored | ||
| cases. Protocol suites passed 19/19, 10/10 and 18/18. Actual restricted-command | ||
| dispatch with the fresh helper and Electron passed 15/15 without skips. | ||
| - Frozen dependency installation, the nine-package Daemon build graph and | ||
| Desktop CI typecheck passed. Dependency-security regressions passed 173/173; | ||
| release/extractor contracts passed 117/117. Installer/NSIS/signing-feasibility | ||
| tests passed 36 cases, with four existing Windows-only cases skipped on macOS. | ||
| - License policy passed for 1,282 versions across 23 families. Windows execution, | ||
| installer acceptance, complete hosted CI, final App/archive bytes, real signing, | ||
| notarization, clean-machine and GUI acceptance remain separate checks. | ||
|
|
||
| No approval refresher, fallback reader, disabled guard or new safety capability | ||
| was introduced. Earlier reviews retain their historical snapshots and limits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.