perf: hoist tile/clamp out of highp sampler inner loop#177
Open
bhark wants to merge 1 commit into
Open
Conversation
Collaborator
|
Nice! There were no const generics in Rust when this code was originally written. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a series linked to #174.
What
Hoists
tile()/clamp/y*strideout of the inner loop of the bicubic and bilinear samplers inhighp. Deadsample()helper is removed. The two sampler functions have been collapsed, as they're very similar after this work.Why
tile()is opaque to LLVM, so it never gets CSE'd out of the inner loop. Hoisting drops the cost per-stage, such that the inner body collapses to one i32 add + bitcast + gather + load + mad.Results
patterns::hq(bicubic, sampler N=4)patterns::lq(bilinear, sampler N=2)patterns::plaingradients::*,fill::*,blend::*No regressions. Benched on an i5-13400F with
-Ctarget-cpu=haswell.Notes
tile,ulp_sub,to_u32x8_bitcast) are unchanged. This is just a scheduling change.sample()path.