Skip to content

fix: remove fixed engines field and add npm install cooldown #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
odanado wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix: remove fixed engines field and add npm install cooldown #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe34480
fix npm config and use npm v12
odanado Aug 31, 2026
f211cc9
fix: bump Node.js to 22.23.2 to install npm v12
odanado Aug 31, 2026
d32de42
chore: review dependency install scripts with allowScripts
odanado Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/code-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
echo "${tmpdir}" >> "$GITHUB_PATH"

- run: mkcert localhost
- run: npm install -g npm@12

@odanado odanado Aug 31, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No Node.js release bundles npm 12 yet, so npm install -g npm@12 is added before npm ci in the workflows. Contributors need to run it locally as well.

- run: npm ci
- run: npm run code-check
- run: npm run test
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
with:
node-version-file: ./.nvmrc

- run: npm install -g npm@12
- run: npm ci
- run: node --run build

Expand Down
2 changes: 1 addition & 1 deletion .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
engine-strict=true
save-exact=true
registry=https://registry.npmjs.org/
min-release-age=3
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
22.2.0
22.23.2

@odanado odanado Aug 31, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm 12 requires Node.js ^22.22.2 || ^24.15.0 || >=26.0.0, so .nvmrc is bumped from 22.2.0 to 22.23.2 (the latest 22 LTS), and @types/node follows it to 22.20.1.

43 changes: 13 additions & 30 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 13 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,24 @@
"release": "changelogen --release"
},
"keywords": [],
"engines": {
"node": "22.2.0",
"npm": "10.7.0"
"devEngines": {
"packageManager": {
"name": "npm",
"version": ">=12.0.0",
"onFail": "error"
}
},
"allowScripts": {
"esbuild": false,
"fsevents": false,
"msw": false,
"node-pty": false
},
"license": "Apache-2.0",
"devDependencies": {
"@types/http-proxy": "1.17.15",
"@types/inquirer": "9.0.7",
"@types/node": "22.2.0",
"@types/node": "22.20.1",
"@typescript-eslint/eslint-plugin": "6.7.3",
"@typescript-eslint/parser": "6.7.3",
"changelogen": "0.5.5",
Expand Down
Loading