Skip to content

Fix code scanning errors - #26

Merged
jcabannes merged 5 commits into
masterfrom
fix-code-scanning-errors
Apr 5, 2024
Merged

Fix code scanning errors#26
jcabannes merged 5 commits into
masterfrom
fix-code-scanning-errors

Conversation

@jcabannes

@jcabannes jcabannes commented Apr 4, 2024

Copy link
Copy Markdown
Member

No description provided.

@jcabannes
jcabannes requested a review from guimard April 4, 2024 17:16
@jcabannes jcabannes self-assigned this Apr 4, 2024
github-advanced-security[bot]
github-advanced-security AI found potential problems Apr 4, 2024
View reviewed changes
Comment thread packages/federation-server/src/routes/routes.ts
conf.trust_x_forwarded_for,
logger
),
auth(authenticate),

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [authorization](1), but is not rate-limited.
Comment thread packages/federation-server/src/routes/routes.ts
conf.trust_x_forwarded_for,
logger
),
auth(authenticate),

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [authorization](1), but is not rate-limited.
Comment thread packages/federation-server/src/routes/routes.ts
conf.trust_x_forwarded_for,
logger
),
auth(authenticate),

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [authorization](1), but is not rate-limited.
Comment thread packages/tom-server/src/room-tags-api/routes/index.ts
router.get(
`${PATH}/:roomId`,
authenticator,
auth,

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [authorization](1), but is not rate-limited.
Comment thread packages/tom-server/src/room-tags-api/routes/index.ts
router.post(
PATH,
authenticator,
auth,

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [authorization](1), but is not rate-limited.
Comment thread packages/tom-server/src/room-tags-api/routes/index.ts
router.put(
`${PATH}/:roomId`,
authenticator,
auth,

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [authorization](1), but is not rate-limited.
Comment thread packages/tom-server/src/room-tags-api/routes/index.ts
router.delete(
`${PATH}/:roomId`,
authenticator,
auth,

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [authorization](1), but is not rate-limited.
Comment thread packages/matrix-identity-server/src/validate/email/requestToken.ts Fixed
@jcabannes
jcabannes force-pushed the fix-code-scanning-errors branch from d8d658f to 42b48e7 Compare April 4, 2024 19:01
github-advanced-security[bot]
github-advanced-security AI found potential problems Apr 4, 2024
View reviewed changes
Comment thread packages/federation-server/src/routes/routes.ts Fixed
Comment thread packages/federation-server/src/routes/routes.ts Fixed
Comment thread packages/federation-server/src/routes/routes.ts Fixed
Comment thread packages/tom-server/src/room-tags-api/routes/index.ts Fixed
Comment thread packages/tom-server/src/room-tags-api/routes/index.ts Fixed
Comment thread packages/tom-server/src/room-tags-api/routes/index.ts Fixed
Comment thread packages/tom-server/src/room-tags-api/routes/index.ts Fixed
@jcabannes
jcabannes force-pushed the fix-code-scanning-errors branch from 42b48e7 to b2b669a Compare April 5, 2024 07:28
@jcabannes
jcabannes merged commit 6726544 into master Apr 5, 2024
@jcabannes
jcabannes deleted the fix-code-scanning-errors branch April 23, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guimard guimard guimard approved these changes

Assignees

@jcabannes jcabannes

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jcabannes @guimard @github-advanced-security @jcabannes932