Repository navigation
fix(hy-emit): infer comparable constraint in select headers, places, and array lengths (fixes #2127) - #2134
Open
jpereyra243-byte wants to merge 1 commit into
Conversation
…and array lengths (fixes limitlessprojects#2127)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
compiler/crates/hy-emit/src/lib.rs, generic type parameter inference for Go'scomparableconstraint (collect_comparable_in_ty/collect_comparable_in_stmt) skipped three AST positions wheremap[k]vorset[k]expressions can appear:SelectArmKind::Send(chanandvalue) andSelectArmKind::Recv(chan) header expressions insideStmt::Select.PlaceKind::Index,PlaceKind::Field,PlaceKind::AddrOf) inStmt::Assignviacollect_comparable_in_place.len: Option<Box<Expr>>) inTypeExpr::Array.When generic parameter
kappeared as a key only in those sites,hy-emitemittedfunc fn_name[k any]instead of[k comparable], leading togo buildfailureinvalid map key type k (missing comparable constraint)(Row 13 BUILDABLE violation).Fixes #2127.
Changes
collect_comparable_in_placeincompiler/crates/hy-emit/src/lib.rsto inspect indexes and projections in assignment targets.targetsinStmt::Assignusingcollect_comparable_in_place.Stmt::Selectarm headers.leninTypeExpr::Array.compiler/crates/hy-emit/tests/comparable_inference_select_places_lengths.rs.Settlement / Payout Wallet (Polygon / USDC):
0xC175c34c256598C7e1AD5B15503cFcED7Ed67e10