Skip to content

fix readme#19

Merged
limit7412 merged 2 commits into
masterfrom
develop
Apr 9, 2026
Merged

fix readme#19
limit7412 merged 2 commits into
masterfrom
develop

Conversation

@limit7412
Copy link
Copy Markdown
Owner

@limit7412 limit7412 commented Apr 9, 2026

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@limit7412 limit7412 merged commit d59235d into master Apr 9, 2026
0 of 2 checks passed
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README to reflect the transition from GraalVM to scala-cli and Scala Native. The review feedback suggests improving the Japanese technical writing style by using hiragana for auxiliary verbs, adding spaces around English terms for better readability, and adopting a more formal tone for the project description.

Comment thread README.md

scalaとGraalVMでlambdaを自力で動かして見たかった話
scalaらしいコードを書けたかというと微妙な気がするがまあいいでしょう
Scala CLI(とScala Native)でAWS Lambdaを自力で動かして見たかった話
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In Japanese technical writing, the auxiliary verb 'miru' (meaning 'to try') is typically written in hiragana ('みたかった') rather than kanji ('見たかった'). Additionally, using half-width parentheses and adding spaces around English terms can improve the readability of the document.

Suggested change
Scala CLI(とScala Native)でAWS Lambdaを自力で動かして見たかった話
scala-cli (と Scala Native) で AWS Lambda を自力で動かしてみたかった話

Comment thread README.md
scalaとGraalVMでlambdaを自力で動かして見たかった話
scalaらしいコードを書けたかというと微妙な気がするがまあいいでしょう
Scala CLI(とScala Native)でAWS Lambdaを自力で動かして見たかった話
Scalaらしいコードを書けたかというと微妙な気がするがまあいいでしょう
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The phrase 'まあいいでしょう' is quite colloquial for a README. Consider using a more formal or descriptive tone to describe the project's status.

Suggested change
Scalaらしいコードを書けたかというと微妙な気がするがまあいいでしょう
Scala らしいコードを書けたかというと微妙な気がしますが、まずは動かすことを目標にしました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant