Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the README to reflect the transition from GraalVM to scala-cli and Scala Native. The review feedback suggests improving the Japanese technical writing style by using hiragana for auxiliary verbs, adding spaces around English terms for better readability, and adopting a more formal tone for the project description.
|
|
||
| scalaとGraalVMでlambdaを自力で動かして見たかった話 | ||
| scalaらしいコードを書けたかというと微妙な気がするがまあいいでしょう | ||
| Scala CLI(とScala Native)でAWS Lambdaを自力で動かして見たかった話 |
There was a problem hiding this comment.
In Japanese technical writing, the auxiliary verb 'miru' (meaning 'to try') is typically written in hiragana ('みたかった') rather than kanji ('見たかった'). Additionally, using half-width parentheses and adding spaces around English terms can improve the readability of the document.
Suggested change
| Scala CLI(とScala Native)でAWS Lambdaを自力で動かして見たかった話 | |
| scala-cli (と Scala Native) で AWS Lambda を自力で動かしてみたかった話 |
| scalaとGraalVMでlambdaを自力で動かして見たかった話 | ||
| scalaらしいコードを書けたかというと微妙な気がするがまあいいでしょう | ||
| Scala CLI(とScala Native)でAWS Lambdaを自力で動かして見たかった話 | ||
| Scalaらしいコードを書けたかというと微妙な気がするがまあいいでしょう |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.