fixs for jcenter down.#248
Closed
icehong wants to merge 3 commits into
Closed
Conversation
icehong
force-pushed
the
master
branch
2 times, most recently
from
bd41fbd to
ce7c36a
Compare
Update AS and gradle version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PullRequest
Great that you are thinking about submitting a PullRequest. Please keep them small if not otherwise possible. Contact me before you are creating a big PR to avoid unnecessary work and rebasing of big PRs. Also try to add tests - I am not religious about that but prefer PRs backed by tests. This project has everything setup for Espresso UI and Unit-tests. Also the existing unit and UI-tests muss pass before submitting a PullRequest. Please base the PullRequests on dev.
PullRequest
Great that you are thinking about submitting a PullRequest!
Please keep them small if not otherwise possible. Contact me before you are c
reating a big PR to avoid unnecessary work and rebasing of big PRs. Also try to
add tests - I am not dogmatic about that but prefer PRs backed by tests. This
project has everything setup for Espresso UI and Unit-tests. Also the existing
unit and UI-tests muss pass before submitting a PullRequest.
Please base the PullRequests on the branch named dev