Repository navigation
ci: lint every commit of a push, not only the last - #34
Merged
Merged
Conversation
--new-from-rev=HEAD~ compares with the merge commit's first parent on a pull request, which covers the whole change, but on a push it covers only the last commit: a rebase merge or a direct push of several commits went through with the earlier ones unlinted. A push now compares with github.event.before, the commit the branch was on before, and checks out the whole history so that commit is there (each repository is a few megabytes). A tag push has no earlier commit and keeps HEAD~.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a push,
--new-from-rev=HEAD~linted only the last commit, so a rebase merge or a direct push of several commits went through with the earlier ones unlinted. A push now compares withgithub.event.before(the commit the branch was on before) and checks out the whole history so that commit is present; the repository is a few megabytes. Pull requests keepHEAD~(the merge commit's first parent, which covers the whole PR) and a two-commit checkout. A tag push has no earlier commit and keepsHEAD~.The push path runs only once this is merged; this PR's own run exercises the pull-request path.