Repository navigation
ci: order runs per branch, a version tag no longer republishes the commit image - #26
Merged
Merged
Conversation
…mmit image Runs are ordered per branch. The image job had its own concurrency group, which only ordered image builds among themselves, after each run's checks: a later push whose checks finished first could publish first and leave the branch tag on the older commit. The group is now on the workflow, so a later push waits for the earlier run. A run that is still waiting gives way to a newer push. A version tag run published the image under the commit tag as well, replacing the one the branch push had published for that commit with a rebuild. A tag run now publishes the version tag only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes from a review of the workflow.
Runs are ordered per branch. The image job had its own concurrency group, which only ordered image builds among themselves, after each run's checks. A later push whose checks finished first could publish first, leaving
:testneton the older commit. The group is now on the workflow: a later push waits for the earlier run. A run that is still waiting gives way to a newer push, so a commit in the middle of a quick series may get no image of its own.A version tag no longer republishes the commit image. The runs for
v0.0.3-rc.1andv0.0.3each pushedworker:0acde8dagain, replacing the image thetestnetpush had published for that commit with a rebuild (same source, different digest). A tag run now publishes the version tag only.Merging pushes to
testnet, so CI publishesworker:testnetandworker:<commit>. It creates no release.