Repository navigation
Drop internal references from comments, scripts and the README - #4
Merged
Merged
Conversation
Comments and the README pointed at the orchestrator's files (scheme docs, manifests, terraform, consumer-api source). npm run openapi now reads the document the API serves, and npm run abi takes the ABI's path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments, scripts and the README pointed at the orchestrator's internal files: the x402 scheme doc, the mainnet manifest, terraform, and consumer-api's source. They're gone, and
dist/no longer carries any of them.npm run openapireads/docs/jsonfrom the network's API (default testnet) instead of loading consumer-api's source. The fixture it writes is byte-identical to the current one.npm run abi -- path/to/IJobRegistry.jsontakes the ABI's path instead of assuming the orchestrator's layout. The generatedsrc/abi.tschanges only in its header line.Typecheck, 65/65 tests, and build pass.