Repository navigation
ci: build the tree and test the fork's packages on every pull request - #13
Merged
Merged
Conversation
Pull requests run go build ./... and go test on the nine packages this fork changes.
… here beacon-chain/blockchain and config/params refuse to run without -tags develop. TestProcessEpoch_CanProcess and TestProcessEpoch_CanProcessBellatrix expect the upstream balances and fail on main as it stands. TestEIP3076SpecTests reads its vectors from a Bazel runfiles directory, which go test does not provide.
…ockchain The config/params loader tests read their data from a Bazel runfiles directory, which go test does not provide. In beacon-chain/blockchain, TestService_HeadSyncCommitteeIndices fails and the assertion helper then panics while printing the difference, which ends the package's run. The fork changes only receive_attestation.go there, so the check runs that file's tests.
Across three runs of the same code, TestAggregateAndSaveForkChoiceAtts_Multiple failed twice and TestProcessLogs_DepositRequestsStarted once (replacement transaction underpriced). Neither is in a file the fork changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a pull-request workflow,
.github/workflows/ci.yml, beside the release workflow.On every pull request
check:go build ./..., thengo test -tags developon the packages this fork changes:beacon-chain/core/altair,beacon-chain/core/epoch,beacon-chain/execution,beacon-chain/operations/attestations,cmd/prysmctl/testnet,config/params,time/slots,validator/client.beacon-chain/blockchainthe fork changes onlyreceive_attestation.go, so the check runs that file's five tests.The rest of the tree is upstream Prysm and is tested there. There is no lint step and no Bazel build. The check took six and a half minutes on its green run.
Skipped by name
It took four runs to get a green one. What they showed, all on
main's code:TestProcessEpoch_CanProcessandTestProcessEpoch_CanProcessBellatrix(core/altair) fail every time: they expect the upstream balances (want: 31999841265, got: 31999841900).TestEIP3076SpecTests,TestLoadConfigFileand the fourTest*ConfigMatchesUpstreamYamltests read their data from a Bazel runfiles directory and cannot run undergo test.TestAggregateAndSaveForkChoiceAtts_Multiplefailed in two runs of three andTestProcessLogs_DepositRequestsStartedin one. Neither is in a file the fork changes.TestService_HeadSyncCommitteeIndices(beacon-chain/blockchain) fails, and the assertion helper then panics while printing the difference, which ends that package's run. That is why the package is narrowed to the attestation tests.Relation to #6
#6 proposes the same baseline with two packages (
core/epoch,cmd/prysmctl) and leavescore/altairout because of the two tests above. This workflow covers those packages and the ones the slot-schedule work touched since.Checked before opening