Recognize & handle brotli compression of the response body#742
Open
n0m0r3pa1n wants to merge 1 commit into
Open
Recognize & handle brotli compression of the response body#742n0m0r3pa1n wants to merge 1 commit into
n0m0r3pa1n wants to merge 1 commit into
Conversation
|
Hello @n0m0r3pa1n do you have a complied Jar file with brotli supported? I have tried to edit and compile, however it shows an error "Caused by: javax.net.ssl.SSLException: Received fatal alert: certificate_unknown" in my project. Many thanks!!! |
Fohlen
suggested changes
Sep 16, 2018
Fohlen
left a comment
Fohlen
left a comment
There was a problem hiding this comment.
This PR seems fine.
However I wonder why doesn't the meteorgroup compile this changes somewhere? Using a private brotli upload seems a bit weird.
Fohlen
suggested changes
Sep 16, 2018
| </dependencies> | ||
| <repositories> | ||
| <repository> | ||
| <id>bintray-nitram509-jbrotli</id> |
There was a problem hiding this comment.
Better not rely on a private bintray repo, why is there no official build?
|
We released brotli support on our fork today. |
|
same issue. why is not merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed Brotli compression recognition because I wanted to get some data from Facebook which use this algorithm.