-
Notifications
You must be signed in to change notification settings - Fork 100
Deploy network arc testnet #1645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
0xDEnYO
wants to merge
21
commits into
main
Choose a base branch
from
deploy-network-arc-testnet
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
d99d926
prepare deployment for arc testnet
0xDEnYO 285a1ab
deployed core setup
0xDEnYO fa9ca22
script fixes
0xDEnYO 64dd968
adds custom handling for missing feePayer error
0xDEnYO d8ec7bf
deployed LiFiIntentEscrowFacet
0xDEnYO 4f8569e
Merge branch 'main' of github.com:lifinance/contracts into deploy-net…
0xDEnYO e956e5d
remove fake private key to silence pre-commit warning
0xDEnYO 6568355
Merge branch 'main' of github.com:lifinance/contracts into deploy-net…
0xDEnYO b7c1a01
update config
0xDEnYO d5ac8c6
deploy PolymerFacet
0xDEnYO 93cee3c
Merge branch 'main' of github.com:lifinance/contracts into deploy-net…
0xDEnYO 60c4753
diamond log updated
0xDEnYO fc1aca6
Merge branch 'main' of github.com:lifinance/contracts into deploy-net…
0xDEnYO 8a83da5
added arc testnet to PolymerCCTPFacet
0xDEnYO a810cb7
deployed updated PolymerCCTPFacet (with arc testnet support) to optim…
0xDEnYO ffd7f46
update diamond log
0xDEnYO e3dfad9
Merge branch 'deploy-network-arc-testnet' of github.com:lifinance/con…
0xDEnYO 3bafeaf
Merge branch 'main' of github.com:lifinance/contracts into deploy-net…
0xDEnYO 80c0548
Add missing Polymer chain id mappings. Used for testing.
gvladika cd405fc
arctestnet logs updates after new PolymerCCTPFacet update
mirooon 47aa041
Merge branch 'main' into deploy-network-arc-testnet
mirooon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| { | ||
| "LiFiDiamond": { | ||
| "Facets": { | ||
| "0x81Aa26F9c9b9d5DE24b61b36dD602da7755aC769": { | ||
| "Name": "DiamondCutFacet", | ||
| "Version": "1.0.0" | ||
| }, | ||
| "0xe60F67d9963977C929eF6Dc465c9874290F746aa": { | ||
| "Name": "DiamondLoupeFacet", | ||
| "Version": "1.0.0" | ||
| }, | ||
| "0x037E643C2ABf0A065eB19554b096CFc11328de33": { | ||
| "Name": "AccessManagerFacet", | ||
| "Version": "1.0.0" | ||
| }, | ||
| "0xe44bd998661194534CAAEa44dAb7512e7Fc11D52": { | ||
| "Name": "CalldataVerificationFacet", | ||
| "Version": "1.3.1" | ||
| }, | ||
| "0xF610Ad5028e9ac3b0E3bBF0761d3EFae994F341e": { | ||
| "Name": "EmergencyPauseFacet", | ||
| "Version": "1.0.1" | ||
| }, | ||
| "0xCC66A5dBcD2528E93FFA515a849132e9C3F2F5A2": { | ||
| "Name": "GenericSwapFacet", | ||
| "Version": "1.0.0" | ||
| }, | ||
| "0xbc140b5ecE539c2A73878badC5014F33F5fe0d83": { | ||
| "Name": "GenericSwapFacetV3", | ||
| "Version": "1.0.2" | ||
| }, | ||
| "0x23Abcd6a3B11A161B044EEe5448ACc1c71a280A0": { | ||
| "Name": "OwnershipFacet", | ||
| "Version": "1.0.0" | ||
| }, | ||
| "0xffdF032efC87a5ae95a133637d8F10A5C8e9AC0c": { | ||
| "Name": "PeripheryRegistryFacet", | ||
| "Version": "1.0.0" | ||
| }, | ||
| "0xb0AF986eACb968B7bf0116C0AC1769D47E97cb40": { | ||
| "Name": "WhitelistManagerFacet", | ||
| "Version": "1.1.0" | ||
| }, | ||
| "0xf8c32B42ddA2CEE4085Bb762FaaA83f34FE6Ad7A": { | ||
| "Name": "WithdrawFacet", | ||
| "Version": "1.0.0" | ||
| }, | ||
| "0x71e7fF4A8186CC3DA73e39BFd918Bb27DFb688c2": { | ||
| "Name": "LiFiIntentEscrowFacet", | ||
| "Version": "1.0.1" | ||
| }, | ||
| "0x9a01A05F3Ce4B36c88bfE40F546D4F856B177875": { | ||
| "Name": "PolymerCCTPFacet", | ||
| "Version": "2.0.1" | ||
| } | ||
| }, | ||
| "Periphery": { | ||
| "ERC20Proxy": "0x27139fC566d78e743Fb8B0E845069676DaA94aEd", | ||
| "Executor": "0x7e0fD1839BC95c2F91E6934e823EA4C30F48DAD2", | ||
| "FeeCollector": "0x949343d563394016CE0c52bB6511DFE5aEec8e8a", | ||
| "FeeForwarder": "0xD23FB66108971325f302bF0f209216D705adF987", | ||
| "GasZipPeriphery": "", | ||
| "LiFiDEXAggregator": "0x3089b3b207E051b2c035c6163874732a18F28bbd", | ||
| "LidoWrapper": "", | ||
| "Patcher": "", | ||
| "Permit2Proxy": "0x36C800D4472fBb888D034Aa74778f481aEE01FEc", | ||
| "ReceiverAcrossV3": "", | ||
| "ReceiverAcrossV4": "", | ||
| "ReceiverChainflip": "", | ||
| "ReceiverOIF": "", | ||
| "ReceiverStargateV2": "", | ||
| "TokenWrapper": "" | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| "AccessManagerFacet": "0x037E643C2ABf0A065eB19554b096CFc11328de33", | ||
| "CalldataVerificationFacet": "0xe44bd998661194534CAAEa44dAb7512e7Fc11D52", | ||
| "DiamondCutFacet": "0x81Aa26F9c9b9d5DE24b61b36dD602da7755aC769", | ||
| "DiamondLoupeFacet": "0xe60F67d9963977C929eF6Dc465c9874290F746aa", | ||
| "EmergencyPauseFacet": "0xF610Ad5028e9ac3b0E3bBF0761d3EFae994F341e", | ||
| "GenericSwapFacet": "0xCC66A5dBcD2528E93FFA515a849132e9C3F2F5A2", | ||
| "GenericSwapFacetV3": "0xbc140b5ecE539c2A73878badC5014F33F5fe0d83", | ||
| "OwnershipFacet": "0x23Abcd6a3B11A161B044EEe5448ACc1c71a280A0", | ||
| "PeripheryRegistryFacet": "0xffdF032efC87a5ae95a133637d8F10A5C8e9AC0c", | ||
| "WhitelistManagerFacet": "0xb0AF986eACb968B7bf0116C0AC1769D47E97cb40", | ||
| "WithdrawFacet": "0xf8c32B42ddA2CEE4085Bb762FaaA83f34FE6Ad7A", | ||
| "LiFiDiamond": "0xFf70F4A1d11995621854F3692acF286d8aCd04b2", | ||
| "ERC20Proxy": "0x27139fC566d78e743Fb8B0E845069676DaA94aEd", | ||
| "Executor": "0x7e0fD1839BC95c2F91E6934e823EA4C30F48DAD2", | ||
| "FeeCollector": "0x949343d563394016CE0c52bB6511DFE5aEec8e8a", | ||
| "FeeForwarder": "0xD23FB66108971325f302bF0f209216D705adF987", | ||
| "LiFiDEXAggregator": "0x3089b3b207E051b2c035c6163874732a18F28bbd", | ||
| "Permit2Proxy": "0x36C800D4472fBb888D034Aa74778f481aEE01FEc", | ||
| "LiFiTimelockController": "0xBBE888016df347C799de8e7787A239aa105F4ce8", | ||
| "LiFiIntentEscrowFacet": "0x71e7fF4A8186CC3DA73e39BFd918Bb27DFb688c2", | ||
| "PolymerCCTPFacet": "0x9a01A05F3Ce4B36c88bfE40F546D4F856B177875" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fail fast if
UpdateDiamondLoupeFacetfails.On Line 192, the new
diamondUpdateFacetcall is not checked. If it fails butUpdateCoreFacetssucceeds, Stage 3 can still appear successful with a partial facet update.Suggested fix
echo "[info] >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> now adding DiamondLoupeFacet to diamond contract" diamondUpdateFacet "$NETWORK" "$ENVIRONMENT" "$DIAMOND_CONTRACT_NAME" "UpdateDiamondLoupeFacet" false + checkFailure $? "add DiamondLoupeFacet to $DIAMOND_CONTRACT_NAME on network $NETWORK" + echo "[info] <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< DiamondLoupeFacet update completed"As per coding guidelines
.cursor/rules/002-architecture.mdc, selector/facet update steps are critical invariants and should be explicitly cross-checked.🤖 Prompt for AI Agents