Skip to content

add cursor command for deprecating a contract#1591

Draft
0xDEnYO wants to merge 4 commits intomainfrom
my-fix-branch
Draft

add cursor command for deprecating a contract#1591
0xDEnYO wants to merge 4 commits intomainfrom
my-fix-branch

Conversation

@0xDEnYO
Copy link
Copy Markdown
Contributor

@0xDEnYO 0xDEnYO commented Jan 21, 2026

Which Jira task belongs to this PR?

Why did I implement it this way?

Checklist before requesting a review

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

  • I have checked that any arbitrary calls to external contracts are validated and or restricted
  • I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
  • I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on by <company/auditor>

@lifi-action-bot lifi-action-bot marked this pull request as draft January 21, 2026 09:49
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 21, 2026

Walkthrough

This PR adds a new contract deprecation command documentation file and updates the existing network deprecation command, while extending the pre-commit hook's secret scanning exclusion list to include the .cursor/commands/ directory.

Changes

Cohort / File(s) Summary
Deprecation Command Documentation
.cursor/commands/deprecate-contract.md, .cursor/commands/deprecate-network.md
Adds comprehensive contract deprecation guide with discovery, validation, reference analysis, and removal workflow; updates network deprecation command with manual Product Target Sheet update reminder and enhanced post-deprecation user interaction flow.
Pre-commit Hook Configuration
.husky/pre-commit
Extends excluded paths in secret scanning to include .cursor/commands/ directory.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested labels

AuditNotRequired

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely a blank template with no custom content filled in. Critical sections like 'Which Jira task', 'Why implemented this way', and checklist items are all empty or unchecked, providing no context for reviewers. Fill in the Jira task reference, explain the implementation rationale, and verify relevant checklist items. At minimum, address why this cursor command was added and document any related changes.
Title check ❓ Inconclusive The title 'Check' is vague and generic, providing no meaningful information about the changeset which adds deprecation commands for contracts and networks. Use a more descriptive title such as 'Add cursor commands for deprecating contracts and networks' to clearly communicate the main changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch my-fix-branch

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@0xDEnYO 0xDEnYO changed the title Check add cursor command for deprecating a contract Jan 21, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.cursor/commands/deprecate-network.md (1)

39-47: Add language identifiers to fenced code blocks (MD040).

Fenced blocks at Line 39–47 and Line 255+ have no language tag. Suggest bash for command examples and text for output blocks.

♻️ Suggested fix
-```
+```bash
 /deprecate-network fantom

```diff
-```
+```bash
 /deprecate-network fantom harmony evmos

```diff
-```
+```text
 Deprecating networks: fantom, harmony

Also applies to: 255-334

🤖 Fix all issues with AI agents
In @.cursor/commands/deprecate-network.md:
- Around line 112-116: Replace the bare Google Sheets URL in the
deprecate-network markdown bullets with proper Markdown link syntax: locate the
bullet lines that contain the plain URL referencing the Product Target State
spreadsheet (the lines describing "The spreadsheet tracks contract deployments
across networks" and the deprecated networks instructions) and convert the raw
URL into a markdown link like [Product Target State
spreadsheet](https://docs.google.com/...) so the link is not a bare URL; apply
the same change for the other occurrence mentioned in the comment.

Comment on lines +112 to +116
- Display a prominent reminder to manually update the Product Target State spreadsheet
- The spreadsheet tracks contract deployments across networks: https://docs.google.com/spreadsheets/d/1jX1wfFkSn1s19I_KzMA7vB1kfgGxXUv7kRqwUGJJLF4/edit#gid=0
- For deprecated networks: Move the network row(s) to the deprecated section
- This is a manual step that must be done separately as the spreadsheet is not part of the codebase

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Convert bare URLs to markdown links (MD034).

Bare URLs in prose (Line 112–115 and Line 225–228) trigger markdownlint. Use markdown link syntax instead.

♻️ Suggested fix
-   - The spreadsheet tracks contract deployments across networks: https://docs.google.com/spreadsheets/d/1jX1wfFkSn1s19I_KzMA7vB1kfgGxXUv7kRqwUGJJLF4/edit#gid=0
+   - The spreadsheet tracks contract deployments across networks: [Product Target State spreadsheet](https://docs.google.com/spreadsheets/d/1jX1wfFkSn1s19I_KzMA7vB1kfgGxXUv7kRqwUGJJLF4/edit#gid=0)
-- **Spreadsheet URL**: https://docs.google.com/spreadsheets/d/1jX1wfFkSn1s19I_KzMA7vB1kfgGxXUv7kRqwUGJJLF4/edit#gid=0
+- **Spreadsheet URL**: [Product Target State spreadsheet](https://docs.google.com/spreadsheets/d/1jX1wfFkSn1s19I_KzMA7vB1kfgGxXUv7kRqwUGJJLF4/edit#gid=0)

Also applies to: 223-229

🤖 Prompt for AI Agents
In @.cursor/commands/deprecate-network.md around lines 112 - 116, Replace the
bare Google Sheets URL in the deprecate-network markdown bullets with proper
Markdown link syntax: locate the bullet lines that contain the plain URL
referencing the Product Target State spreadsheet (the lines describing "The
spreadsheet tracks contract deployments across networks" and the deprecated
networks instructions) and convert the raw URL into a markdown link like
[Product Target State spreadsheet](https://docs.google.com/...) so the link is
not a bare URL; apply the same change for the other occurrence mentioned in the
comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants