[I-1] Incorrect padded length comment

[reednaa]

This PR correctly changes the comment related to ABI padding for the CallReverted event.

It also disabled the bytecode hash embedded inside Solidity contracts.

Summary by CodeRabbit

• Chores

  • Updated build configuration with new bytecode hash option for default profile settings.

• Refactor

  • Clarified internal code documentation for calculation logic.

[coderabbitai]

Walkthrough

A configuration option bytecode_hash = 'none' was added to foundry.toml under the default profile. A comment in ERC7821LIFI.sol was updated to clarify an ABI-padding calculation expression while maintaining equivalent functionality.

Changes

Cohort / File(s)	Summary
Configuration Update foundry.toml	Added bytecode_hash = 'none' configuration option under [profile.default] section
Documentation Update src/libs/ERC7821LIFI.sol	Updated inline comment describing ABI-padding calculation from (rdsize + rdsize % 32) to ((rdsize + 31) / 32 * 32) for clarity; no functional logic changes

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Both changes are cosmetic: a simple configuration addition and a comment clarification with no logic modifications
• No control flow or behavior alterations present

Poem

🐰 A config here, a comment there,
Bytecode hashed with utmost care,
Padding expressions, crystal clear,
No logic changed—just polish here! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title '[I-1] Incorrect padded length comment' accurately reflects the main change in the pull request—a comment correction in the ABI-padding calculation. The title is specific, concise, and clearly summarizes the primary modification.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch incorrect-padding-comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 19e16e4 and 9f7cded.

📒 Files selected for processing (2)

• foundry.toml (1 hunks)
• src/libs/ERC7821LIFI.sol (1 hunks)

🔇 Additional comments (3)

foundry.toml (1)

9-9: Verify the intent to disable bytecode hash metadata.

Setting bytecode_hash = 'none' disables the embedded metadata hash (IPFS/Swarm) in deployed contracts. While this achieves deterministic builds and reduces bytecode size, it prevents automatic source verification via the embedded hash on block explorers.

Please confirm this is the intended behavior for your deployment strategy.

src/libs/ERC7821LIFI.sol (2)

151-152: Excellent correction to the padding comment.

The previous comment incorrectly described the padding calculation as (rdsize + rdsize % 32), which does not round up to a multiple of 32. The new comment ((rdsize + 31) / 32 * 32) accurately describes what the code does: rounds up the return data size to the nearest multiple of 32 for ABI alignment.

The assembly code and(add(returndatasize(), 31), not(31)) is bitwise equivalent to this formula and was always correct—only the comment was inaccurate.

---

156-157: Good clarification on the event emission.

Adding the event name CallReverted to the comment improves code readability and makes it immediately clear which event is being logged.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}