-
Notifications
You must be signed in to change notification settings - Fork 855
fix(responses): strip output-only reasoning status unconditionally #2252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
olddonkey
wants to merge
20
commits into
lidge-jun:dev
from
olddonkey:fix/reasoning-status-unconditional
Closed
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d6c6a31
fix(xai): restore Grok Responses tool compatibility
olddonkey e4508d0
fix(responses): address namespace review findings
olddonkey add8a55
fix(responses): keep compaction blobs on the backend that minted them
olddonkey 3d11f6f
fix(responses): stop reshaping reasoning items that carry encrypted_c…
olddonkey bf84d17
fix(responses): close the remaining private-shape leaks on the routed…
olddonkey d8426a6
fix(responses): drop a null reasoning content channel before routed p…
olddonkey 6e86b18
fix(responses): scope the null-content strip to routed destinations
olddonkey 6bede37
fix(responses): make namespace dedup order-independent and restore cu…
olddonkey abc2b9f
fix(responses): decide native-blob relay by destination, not by forwa…
olddonkey 10b68d2
docs(responses): stop asserting a disproven cause for the blob-preser…
olddonkey c3d62b0
fix(responses): drop reasoning blobs and output-only status across a …
olddonkey 2dd6685
Merge branch 'fix/compaction-blob-provenance' into integration/grok-r…
olddonkey 847cd8a
Merge branch 'fix/xai-reasoning-replay-integrity' into integration/gr…
olddonkey fbce515
Merge branch 'fix/reasoning-null-content-channel' into integration/gr…
olddonkey 4f9f728
fix(responses): compare the serving identity on rotation-safe dimensions
olddonkey 26ed833
Merge branch 'fix/cross-backend-reasoning-replay' into integration/gr…
olddonkey 248a75c
fix(responses): compare serving identity for compaction blobs too
olddonkey 3b328ef
fix(responses): recover when an upstream rejects foreign opaque state
olddonkey 3927a43
Merge branch 'fix/blob-provenance-recovery' into integration/grok-res…
olddonkey 1bbb63b
fix(responses): strip output-only reasoning status unconditionally
olddonkey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: lidge-jun/opencodex
Length of output: 175
🏁 Script executed:
Repository: lidge-jun/opencodex
Length of output: 17030
🏁 Script executed:
Repository: lidge-jun/opencodex
Length of output: 4582
🏁 Script executed:
Repository: lidge-jun/opencodex
Length of output: 4323
Remove the duplicate compaction type enumeration.
src/server/responses/core.ts:424-429repeats the three compaction types. UseisCompactionItemType(candidate.type)inoutboundResponsesBodyCarriesOpaqueBloband keep only"reasoning"as a local special case. Otherwise, future changes to the shared list can bypass opaque-blob recovery.🤖 Prompt for AI Agents