Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/adapters/cursor/live-transport.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1129,7 +1129,7 @@ class LiveCursorTransport implements CursorTransport {
}
releaseBacklogLease();
settler.settleFinish();
}, (err) => {
}).catch((err) => {
failAndClear(err instanceof Error ? err : new Error(String(err)));
});
};
Expand Down
54 changes: 54 additions & 0 deletions tests/cursor-hardening.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -623,6 +623,60 @@ describe("Cursor live transport unexpected EOF", () => {
expect(seenSessionId).toBe("cursor_from_gjc_session");
});

test("settles as a failure when clean EOF synthesis exceeds the transport budget", async () => {
const textFrame = encodeConnectFrame(toBinary(AgentServerMessageSchema, create(AgentServerMessageSchema, {
message: {
case: "interactionUpdate",
value: create(InteractionUpdateSchema, {
message: {
case: "textDelta",
value: create(TextDeltaUpdateSchema, { text: "x" }),
},
}),
},
})));
const connectEnd = encodeConnectFrame(new TextEncoder().encode("{}"), {
flags: CONNECT_FLAG_END_STREAM,
});

await withDiscoveryServer(stream => {
stream.respond({ ":status": 200, "content-type": "application/connect+proto" });
stream.end(Buffer.from(new Uint8Array([
...Array.from({ length: 37 }, () => [...textFrame]).flat(),
...connectEnd,
])));
}, async baseUrl => {
const budget = createTestTranslatorBudget({ maxTurnBytes: 1_000 });
const transport = createLiveCursorTransport({
provider: { adapter: "cursor", baseUrl, apiKey: "test-token" },
translatorBudget: budget,
firstFrameTimeoutMs: 2_000,
});
const iterator = transport.run({
modelId: "composer-2",
conversationId: "cursor_clean_eof_budget_test",
system: [],
messages: [{ role: "user", content: "hello" }],
})[Symbol.asyncIterator]();
let failure: Error | undefined;
try {
expect(await iterator.next()).toMatchObject({ value: { type: "text" } });
await Bun.sleep(20);
while (!(await iterator.next()).done) {}
} catch (err) {
failure = err instanceof Error ? err : new Error(String(err));
} finally {
await transport.close?.();
}

expect(failure).toMatchObject({
name: "TranslatorBudgetExceededError",
code: "translation_buffer_limit",
});
expect(budget.snapshot().currentBytes).toBe(0);
});
});

test("synthesizes done after createPlanRequestQuery text on clean Connect EOF", async () => {
const planFrame = encodeConnectFrame(toBinary(AgentServerMessageSchema, create(AgentServerMessageSchema, {
message: {
Expand Down
Loading