-
Notifications
You must be signed in to change notification settings - Fork 868
fix(xai): restore default Grok 4.5/4.6 Responses requests #2217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
olddonkey
wants to merge
4
commits into
lidge-jun:dev
from
olddonkey:codex/fix-xai-responses-namespace-tools
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d6c6a31
fix(xai): restore Grok Responses tool compatibility
olddonkey e4508d0
fix(responses): address namespace review findings
olddonkey bf84d17
fix(responses): close the remaining private-shape leaks on the routed…
olddonkey 6bede37
fix(responses): make namespace dedup order-independent and restore cu…
olddonkey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
One wire-name rule is now implemented twice.
customToolWireNameandloweredWireNameare byte-for-byte the same rule, and each file declares its own privateBUILTIN_FUNCTIONS_NAMESPACE = "functions"constant. These two copies form a single contract: the namespace layer produces the wire name, and the custom-tool layer must reproduce it exactly to match a restoration entry. If one copy changes and the other does not, the mismatch is silent — no throw, no log, just acustom_tool_callthat is never restored and reaches the client as afunction_call.src/responses/custom-tool-compat.ts#L20-L22: delete the localcustomToolWireNameand the localBUILTIN_FUNCTIONS_NAMESPACE, and import the shared helper instead.src/responses/namespace-tool-compat.ts#L77-L79: moveloweredWireNameand theBUILTIN_FUNCTIONS_NAMESPACEconstant into a shared module (for examplesrc/responses/tool-groups.ts, which both files already import), export it, and call it from both layers.📍 Affects 2 files
src/responses/custom-tool-compat.ts#L20-L22(this comment)src/responses/namespace-tool-compat.ts#L77-L79🤖 Prompt for AI Agents