-
Notifications
You must be signed in to change notification settings - Fork 866
fix(codex): gate account-native models by entitlement #2101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
aac1177
fix(codex): gate account-native models by entitlement
Ingwannu 5c303a6
fix(codex): tolerate extended gated-model shard drift
Ingwannu 4acb884
fix(codex): stabilize Daybreak wire requests
Ingwannu e01b2fb
fix(codex): route Daybreak compaction through responses
Ingwannu d3fe560
docs(codex): explain Daybreak compact streaming
Ingwannu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: lidge-jun/opencodex
Length of output: 157
🏁 Script executed:
Repository: lidge-jun/opencodex
Length of output: 50375
🏁 Script executed:
Repository: lidge-jun/opencodex
Length of output: 30934
🏁 Script executed:
Repository: lidge-jun/opencodex
Length of output: 29633
🏁 Script executed:
Repository: lidge-jun/opencodex
Length of output: 559
🏁 Script executed:
Repository: lidge-jun/opencodex
Length of output: 41099
Scope native OpenAI availability by account mode
nativeOpenAiSlugs()atsrc/codex/catalog/metadata.ts:486-493reads the entitlement cache without eligible account IDs, so Direct mode accepts confirmed Pool-account evidence. The plain/v1/modelspath usesvisibleNativeSlugs(config)atsrc/server/index.ts:1095, which callsnativeOpenAiSlugs()without config; the filter at lines 938-940 applies only to the Codex catalog branch. A Pool-only roster can therefore advertisegpt-daybreak-blue-latestas a bare model even though Direct routing accepts only the main account.nativeModelRows, catalog sync, and convergence already restrict this projection toMAIN_CODEX_ACCOUNT_IDin Direct mode.Add the optional
providersconfig tonativeOpenAiSlugs, pass it throughvisibleNativeSlugs(config), and update the config-aware server and catalog callers. Usenew Set([MAIN_CODEX_ACCOUNT_ID])whenproviderCodexAccountMode(...) === "direct".🧰 Tools
🪛 ast-grep (0.45.1)
[warning] Importing child_process exposes a command-execution surface; ensure any command/argument built from input is validated, and prefer execFile/spawn with an argument array over exec.
Context: import { execFileSync } from "node:child_process";
Note: [CWE-78] Improper Neutralization of Special Elements used in an OS Command ('OS Command Injection').
(detect-child-process-typescript)
🤖 Prompt for AI Agents